Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stupid PA recipe handling #536

Closed
draknyte1 opened this issue Aug 28, 2019 · 1 comment
Closed

Fix Stupid PA recipe handling #536

draknyte1 opened this issue Aug 28, 2019 · 1 comment
Assignees
@draknyte1
Labels
enhancement/suggestion/idea minor Not my fault

Comments

@draknyte1
Copy link
Collaborator

So this code is disgusting.
https://github.com/Blood-Asp/GT5-Unofficial/blob/7b592a645c91bd5f3ef76189af7936908b427301/src/main/java/gregtech/common/tileentities/machines/multi/GT_MetaTileEntity_ProcessingArray.java#L67

Proposal: replace with a dynamic map, this is to be done directly to GT via a PR, however, it will also be added via ASM to previous versions. Other mods can register machines and recipe maps via the GT++ API, to avoid GT versioning hassles.

Result: machines such as the Simple Washer or Dehydrator can be used within the PA.
@draknyte1 draknyte1 self-assigned this Aug 28, 2019
@draknyte1 draknyte1 mentioned this issue Jan 9, 2020
Closed
@draknyte1
Copy link
Collaborator Author

Fixed in Blood-Asp/GT5-Unofficial#1551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draknyte1 draknyte1

Labels
enhancement/suggestion/idea minor Not my fault
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@draknyte1