Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build changes #303

Merged
merged 6 commits into from
Jun 7, 2022
Merged

Build changes #303

merged 6 commits into from
Jun 7, 2022

Conversation

PatrykMis
Copy link
Contributor

@PatrykMis PatrykMis commented Jun 7, 2022

Description

  • Migrate build logic to fully Kotlin DSL
  • Update dependencies
  • Set JVM target version to 11
  • Update compileSdk, define buildToolsVersion
  • Regression fix: Add verification of the downloaded Gradle distribution via SHA-256 again.

Type of change

Just put an x in the [] which are valid.

  • Translation Contribution (non-breaking change which only adds or updates the translation to a language)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

License:

  • I hereby declare that all my contributions to this project is licensed using the GPL Version 3 License unless specified directly on source files

@allgood allgood merged commit ed44af3 into allgood:master Jun 7, 2022
@allgood
Copy link
Owner

allgood commented Jun 7, 2022

thank you @PatrykMis , please note that I am experimenting some changes on code, mostly on page detection and possibility to tune the image processing algorithms, so, I need to check if changes conflicts with my local branch. This looks good, but if it changes code of classes or manifest, I will not be able to merge.

@PatrykMis PatrykMis deleted the patch-3 branch June 7, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants