Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why we remove String extension .styled( from generated calls? #74

Open
bimawa opened this issue Oct 1, 2020 · 2 comments
Open

Why we remove String extension .styled( from generated calls? #74

bimawa opened this issue Oct 1, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@bimawa
Copy link

bimawa commented Oct 1, 2020

SUBJ But, maybe, this way has a some bad practice?

titleLabel.attributedText = "Title".styled(.H1)

Looks pretty good? Like in Zeplin generation, and Figmagen?
@almazrafi
Copy link
Owner

Hi 👋
I don't see any problems with this. We can implement it soon.
Thanks!

@almazrafi almazrafi added the enhancement New feature or request label Oct 1, 2020
@bimawa
Copy link
Author

bimawa commented Oct 2, 2020

I'm confused with UIColor template too. I can try to make PR for some cases.

@bimawa bimawa mentioned this issue Oct 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bimawa @almazrafi