Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor is deleted when triple click selecting all of the content #1483

Open
ianchadwick opened this issue Oct 22, 2015 · 4 comments
Open

Editor is deleted when triple click selecting all of the content #1483

ianchadwick opened this issue Oct 22, 2015 · 4 comments

Comments

@ianchadwick
Copy link

In an editor with say just:

<p>Replace this text</p>

If you select all of the text by triple clicking and then hit backspace the editor element is deleted.

Seems when you select this way the last selection boundary ends up being editor element.

Selecting content by dragging the mouse and hitting delete works as expected.

See http://jsfiddle.net/o0pkps0x/

@ianchadwick
Copy link
Author

So on further use it seems triple click selecting is more broken, for example.

<h1>A Title</h1>
<p>Edit this content</p>

If you triple click the title and delete it, it removes the title text but moves the content in the p tags in to the h1 tags.

See http://jsfiddle.net/65s2zxqk/

@petrosalema
Copy link
Member

Thank you for offering a patch, @ianchadwick. In order for us to run Aloha Editor as an open source project, we require that all who become contributors first agree and sign the Contributors' Agreement (http://www.alohaeditor.org/docs/contributing.html). Are you happy to do this?

@ianchadwick
Copy link
Author

Sorry for the slow response, I was knee deep in boxes last week and have
just moved house!

No problem signing the agreement, I¹ve email to the [email protected]
email.

Thanks,
Ian

From: Petro Salema [email protected]
Reply-To: alohaeditor/Aloha-Editor
<reply+000b3027554a45eb4ac66b5c17e675d7a95472ee63f2253592cf000000011249c1239
[email protected]>
Date: Thursday, 29 October 2015 11:12
To: alohaeditor/Aloha-Editor [email protected]
Cc: "[email protected]" [email protected]
Subject: Re: [Aloha-Editor] Editor is deleted when triple click selecting
all of the content (#1483)

Thank you for offering a patch, @ianchadwick
https://github.com/ianchadwick . In order for us to run Aloha Editor as an
open source project, we require that all who become contributors first agree
and sign the Contributors' Agreement
(http://www.alohaeditor.org/docs/contributing.html). Are you happy to do
this?


Reply to this email directly or view it on GitHub
<#1483 (comment)
012> .

@ianchadwick
Copy link
Author

Hmm, got a bounce back. Where should I send the agreement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants