Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support asset attributes filter for get_all_assets() #394

Merged
merged 2 commits into from
Dec 27, 2023
Merged

feat: Support asset attributes filter for get_all_assets() #394

merged 2 commits into from
Dec 27, 2023

Conversation

hiohiohio
Copy link
Contributor

Context:

  • we missed attributes parameter for GetAssetsRequest

Changes:

  • add attributes parameter for GetAssetsRequest

@hiohiohio hiohiohio merged commit 9f66b97 into alpacahq:master Dec 27, 2023
5 checks passed
@hiohiohio hiohiohio deleted the support-asset-attributes-filter branch December 27, 2023 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-g sai-g sai-g approved these changes

@AlexandrosKyriakakis AlexandrosKyriakakis Awaiting requested review from AlexandrosKyriakakis

@matebudai matebudai Awaiting requested review from matebudai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiohiohio @sai-g