-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML validation error: 'The group role is unnecessary for element fieldset' in date input #1590
Comments
We did some testing: While
|
Based on our testing we've decided to keep this attribute as it improves IE11 for JAWs users: they will hear the hint and error message being read out. We'll review this if anything changes. |
role=“group”
from date input fieldset
What
We set
role="group"
on the fieldset of the date input component.The W3C Markup Validator flags it as warning
It seems it was added to improve accessibility with Jaws
#681 (comment) and 759fd5a
I’ve done some preliminary testing as part of documenting warnings. I did this with the error message present on the page as the comments suggest that was part of the initial problem. I found no difference in announcements with Jaws 15, Jaws 2018 or NVDA with Firefox with/without
role="group"
. However in Jaws 16 the addition ofrole="group"
made the announcements less helpful:role="group"
, Jaws announced “day edit type of text”role="group"
, “expiry date day edit type of text”I also tested in Jaws 15, 16 and 2018 by skim reading the page (Ctrl+Insert+PageDown) and didn't hear any difference with
role="group"
present/removed.We should do a bit more testing as my initial investigation might have not covered all the possible scenarios.
Why
Who needs to be involved in this
Developers
Done when
The text was updated successfully, but these errors were encountered: