Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Internet Explorer (IE) support in GOV.UK Frontend #2621

Closed
12 of 13 tasks
Tracked by #1389
vanitabarrett opened this issue May 16, 2022 · 7 comments
Closed
12 of 13 tasks
Tracked by #1389

Reduce Internet Explorer (IE) support in GOV.UK Frontend #2621

vanitabarrett opened this issue May 16, 2022 · 7 comments
Labels
epic Epics are used in planning project boards to group related stories javascript

Comments

@vanitabarrett
Copy link
Contributor

vanitabarrett commented May 16, 2022

What

In our next major version (v5) we're reducing our support for Internet Explorer:

  • dropping support completely for IE8 to 10
  • dropping support for JavaScript in IE11 (while keeping support for styling)

CSS

We'll completely remove our support for IE8 to 10. Our components will keep rendering properly and remain functional in IE11 though.

JavaScript

We will no longer support our component's JavaScript enhancement running in any version of Internet Explorer. People using IE11 will get the non-JavaScript version of the components, which will still let them complete their task.

We’ll continue to provide minimal support for v4 for the next 12 months by publishing urgent security updates and major bug fixes (but no new components or features).

Why

We have decided to reduce support for IE11 in GOV.UK Frontend and drop support completely for IE8-10. We shared these proposed changes with the frontend community in GDS and across government, and have only received positive feedback.

We will make these changes in a future breaking release of GOV.UK Frontend (likely v5.0.0).
See our browser proposal for more details.

Impact

Teams still required to support IE11 will remain able to use our components. Those will be lacking their JavaScript enhancement but still allow users to complete their tasks as they are implemented with progressive enhancement in mind.

During the 12 months after the release of v5, they'll also be able to keep using v4, for which JavaScript will keep running in Internet Explorer.

Epic lead

TBD

Who needs to work on this

Developers, Designers, Tech writers

Done when

In v4.x

  1. javascript support
    querkmachine
  2. documentation process tooling
    vanitabarrett
  3. sass / css 🕔 hours
    36degrees

Remove legacy code

  1. sass / css
    querkmachine
  2. sass / css
    querkmachine
  3. documentation javascript performance
  4. 3 of 3
    design details sass / css
  5. documentation
    claireashworth
  6. breaking change header
    querkmachine

Post v5.0

  1. accessibility firebreak0722 🔍 investigation
  2. awaiting triage tech debt
  3. character count javascript
  4. javascript
@vanitabarrett vanitabarrett added epic Epics are used in planning project boards to group related stories javascript javascript squad labels May 16, 2022
@vanitabarrett
Copy link
Contributor Author

Written up a card for us to revisit our support of v4, 12 months after releasing this piece of work. #2626

@colinrotherham
Copy link
Contributor

Just moving some related comments from #3559 (comment) so we don't miss anything:

  1. There's the SVG fallback govuk-logotype-crown.png image to delete:

    <img src="{{ params.assetsPath | default('/assets/images') }}/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image" width="36" height="32" alt="">

    // Hide the inverted crown when printing in browsers that don't support SVG.

  2. Documentation to test in Internet Explorer 8, 9 and 10

    - in [Internet Explorer 8](https://frontend.design-system.service.gov.uk/supporting-ie8/), 9 and 10 - components do not need to look perfect

    Your contribution needs to work with certain browsers as set out in [README](README.md#browser-and-assistive-technology-support). See also [supporting Internet Explorer 8](https://frontend.design-system.service.gov.uk/supporting-ie8/).

    - Internet Explorer 8, 9 and 10, although components may not look perfect

    - [a separate stylesheet](https://frontend.design-system.service.gov.uk/supporting-ie8/) if you support Internet Explorer 8

    This is to ensure compatibility with Internet Explorer 8, which doesn't support the double colon syntax.

    ## Resize text in Internet Explorer versions 8 to 11

@domoscargin
Copy link
Contributor

domoscargin commented May 30, 2023

Capturing some stuff we've been chatting about regarding non-vendor polyfills.

Intl.PluralRules - #3465

Intl.NumberFormat

onpageshow (in character-count, checkboxes, radios)

HTMLDetailsElement (in Details)

matchMedia (in header and tabs)

Some of these we soon won't need. For example, some can be removed once #3508 is complete.

Partially addressed in #3723

@domoscargin
Copy link
Contributor

domoscargin commented May 30, 2023

Some non-obvious IE-related things to remove:

@domoscargin
Copy link
Contributor

Some non-obvious IE-related things to remove:

@querkmachine I have no memory of writing this post, but are these worth cleaning up? Looks like the first two only apply to older IE which we shouldn't need any more. The last one might still be in IE11 and thus in that iffy zone.

@querkmachine
Copy link
Member

@domoscargin They're dealt with!

And yeah, focusable="false" is still necessary for IE11 for the time being.

@domoscargin
Copy link
Contributor

Whoops, I was looking at that commit rather than main. Call it a case of the Mondays.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Epics are used in planning project boards to group related stories javascript
Projects
None yet
Development

No branches or pull requests

6 participants