Document how to use the legacy palette #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1439
|
@m-green would you have any time to review this? Happy to talk it through in person. |
NickColley
approved these changes
Jun 10, 2019
aliuk2012
reviewed
Jun 10, 2019
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1439
aliuk2012
approved these changes
Jun 10, 2019
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1439
|
@36degrees I've rejigged for style and conciseness - let me know what you think. Happy to chat through! |
36degrees
commented
Jun 12, 2019
docs/installation/compatibility.md
Outdated
|
|
||
| ## Compatibility mode | ||
| GOV.UK Frontend components in your pages will: |
There was a problem hiding this comment.
It's not just the components – this would also apply to anything styled using GOV.UK Frontend, for example headings, paragraphs and links.
There was a problem hiding this comment.
Ah good to know, thanks - tweaked in f621496.
docs/installation/compatibility.md
Outdated
| - include adjustments to the CSS to 'counter' specific CSS rules in the legacy | ||
| frameworks | ||
| - use the previous version of the font included with GOV.UK Template | ||
| Set a variable to `false` to turn off compatibility mode for that framework. |
There was a problem hiding this comment.
I think we'd generally encourage people to omit the variable entirely if they're not changing it from the default.
There was a problem hiding this comment.
Thank you - fixed in f621496.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1439
m-green
approved these changes
Jun 13, 2019
36degrees
force-pushed
the
document-legacy-palette-config
branch
from
f621496 to
093e2a2
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1439
It’s hard to talk about this option without also talking about compatibility mode, so this also splits the documentation on compatibility mode out from the installation instructions and adds more detail about what it actually does. Co-authored-by: Mark Green <[email protected]>
36degrees
force-pushed
the
document-legacy-palette-config
branch
from
093e2a2 to
1402166
Compare
|
Squashed into one commit and wrapped at 80 characters. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s hard to talk about this option without also talking about compatibility mode, so this also splits the documentation on compatibility mode out from the installation instructions and adds more detail about what it actually does.
There is some duplication between this and the compatibility mode Sass documentation updated in #1438 – it feels like it does need to be explained in both places. Open to ideas on how to reduce that duplication.
Closes #1432