Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to add additional scripts and stylesheets #1926

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BenSurgisonGDS
Copy link
Contributor

@BenSurgisonGDS BenSurgisonGDS commented Jan 23, 2023

Changes

  • Add an additional block to allow users to add their own global scripts
  • Add additional blocks to allow users to add their own page and global css

@nataliecarey
Copy link
Contributor

We've discussed doing this, I think it would be helpful but I'm also nervous about customising the layouts because:

  • It could conflict with a future change in Frontend
  • It dilutes the use of the kit as a place to experiment with Frontend

I think we should start by discussing this with the Design System Team, then if they don't think it belongs in Frontend we should discuss whether it belongs in the kit. If we don't add it to Frontend or the kit then people who want to work around this should be able to use a plug-in to get the same behaviour.

@joelanman
Copy link
Contributor

we currently cover this using the super() function right?

https://prototype-kit.service.gov.uk/docs/adding-css-javascript-and-images

@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch 3 times, most recently from 38cfd23 to 93c9977 Compare February 2, 2023 09:25
@joelanman
Copy link
Contributor

might this be better as an issue? Then we dont have to keep the code updated and it better reflects the situation as one we're discussing

@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch 3 times, most recently from 1a4ed30 to f3b4ba8 Compare February 8, 2023 17:07
@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch 5 times, most recently from 4420d3a to 78c2633 Compare February 20, 2023 15:05
@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch 3 times, most recently from 3c92b07 to 61637ca Compare February 28, 2023 17:15
@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch 4 times, most recently from 634ed87 to a90a6a4 Compare March 9, 2023 18:09
@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch 7 times, most recently from 1e2db99 to 30f71dd Compare March 20, 2023 18:23
@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch 3 times, most recently from 4b05de0 to 773a661 Compare March 27, 2023 09:21
@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch 2 times, most recently from 0c30b28 to 71eedd2 Compare April 5, 2023 12:45
@BenSurgisonGDS BenSurgisonGDS marked this pull request as draft April 5, 2023 13:05
@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch from 71eedd2 to 8281709 Compare April 6, 2023 12:56
@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch 2 times, most recently from dd964bc to bd59bb7 Compare April 19, 2023 11:13
@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch from bd59bb7 to bbf3621 Compare April 28, 2023 11:03
@BenSurgisonGDS BenSurgisonGDS force-pushed the allow-users-to-add-stylesheets-and-scripts branch from bbf3621 to 04284e2 Compare May 15, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants