New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sanitiser::Strategy::SanitisingError to the list of excluded errors #402

Merged

unoduetre merged 2 commits into main from 2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l

Nov 1, 2024

Contributor

unoduetre commented Oct 17, 2024

⚠️ Make sure you release a new version of this gem after merging your changes. ⚠️

Refer to the existing docs if you are making changes to the supported Ruby versions.

What

Do not send Sanitiser::Strategy::SanitisingError to Sentry. This error should still be raised in all environments.

This error is raised in some apps when an incorrect (wrong UTF-8 encoding) character is encountered in a query string or in a cookie.

Why

unoduetre force-pushed the 2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l branch from c45e890 to 17efe1f Compare

October 17, 2024 14:04

unoduetre added a commit that referenced this pull request


          Release 9.15.0

8807acd

* Add Sanitiser::Strategy::SanitisingError to excluded exceptions list ([#402](#402))

unoduetre added a commit to alphagov/government-frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

3157aff

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit that referenced this pull request


          Release 9.15.0

7b8d453

* Add Sanitiser::Strategy::SanitisingError to excluded exceptions list ([#402](#402))

unoduetre force-pushed the 2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l branch from 8807acd to 7b8d453 Compare

October 23, 2024 13:35

unoduetre added a commit to alphagov/government-frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

9b5f383

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre marked this pull request as ready for review

October 23, 2024 13:43

catalinailie approved these changes

View reviewed changes

hannako mentioned this pull request

Handle incorrectly UTF-8 encoded query and cookie url alphagov/government-frontend#3371

Closed

hannako approved these changes

View reviewed changes

unoduetre added a commit to alphagov/static that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

53fbd61

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre mentioned this pull request

Handle incorrectly UTF-8 encoded query and cookie url alphagov/static#3468

Merged

unoduetre added a commit to alphagov/collections that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

37135b7

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

1433a80

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

88b7b7d

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

This was referenced Oct 25, 2024

Handle incorrectly UTF-8 encoded query and cookie url alphagov/collections#3815

Closed

Handle incorrectly UTF-8 encoded query and cookie url alphagov/frontend#4339

Merged

unoduetre added a commit to alphagov/frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

7e99f3b

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/collections that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

dae6678

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/collections that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

8809d71

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/static that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

0ab655a

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

8ddcb49

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

64396a0

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/static that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

62d300e

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/collections that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

abc1749

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

Contributor Author

unoduetre commented Oct 28, 2024 •

edited

Loading

~~I'm closing this PR as an alternative approach will be used.~~

unoduetre closed this

unoduetre reopened this

unoduetre added a commit to alphagov/collections that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

09dd97d

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/government-frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

7b9aeed

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

This was referenced Oct 28, 2024

Handle incorrectly UTF-8 encoded query and cookie url alphagov/collections#3820

Merged

Handle incorrectly UTF-8 encoded query and cookie url alphagov/government-frontend#3391

Closed

unoduetre added a commit to alphagov/frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

964003e

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/collections that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

db83410

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

517e30d

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/government-frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

310b173

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/static that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

305186f

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/collections that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

3c33dca

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

2884d19

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/government-frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

05a6fc7

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit that referenced this pull request


          Release 9.15.0

849498c

* Add Sanitiser::Strategy::SanitisingError to excluded exceptions list ([#402](#402))

unoduetre force-pushed the 2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l branch from 7b8d453 to 849498c Compare

October 28, 2024 15:19

unoduetre requested a review from AgaDufrat

October 31, 2024 10:40

unoduetre added a commit to alphagov/collections that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

c667e89

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/government-frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

99f3f8e

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/frontend that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

84bbc37

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added a commit to alphagov/static that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

42645db

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

unoduetre added 2 commits

October 31, 2024 11:18


          Exclude Sanitiser::Strategy::SanitisingError

172b97c


          Release 9.15.0

702d38c

* Add Sanitiser::Strategy::SanitisingError to excluded exceptions list ([#402](#402))

unoduetre force-pushed the 2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l branch from 849498c to 702d38c Compare

October 31, 2024 11:19

hannako pushed a commit to alphagov/collections that referenced this pull request


          Handle incorrectly UTF-8 encoded query and cookie url

756cd92

Use a different exception when this situation is detected:
* Sanitiser::Strategy::SanitisingError
This error is not sent to Sentry.
See: alphagov/govuk_app_config#402

deborahchua approved these changes

View reviewed changes

unoduetre merged commit 71007be into main

10 checks passed

unoduetre deleted the 2938-silently-handle-invalid-byte-sequence-in-utf-8-errors-l branch

November 1, 2024 10:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet