fix: Single commit validation does not factor in merge commits [#108]

[julianpoy]

Closes #108

With a recent change, GitHub no longer factors in merge commits added by the "update branch" button into whether to use the PR title. If a dev submits a PR with a single commit, then presses the "update branch" button, action-semantic-pull-request will allow the branch to be merged, however GitHub will still use the commit title rather than the PR title.

[amannn]

Thanks a lot for looking into this! Do you think you could fix the stylistic lint error (yarn lint --fix) and possibly add a comment to the updated lines to explain the situation?

Many thanks!

[julianpoy]

@amannn Done! 😄

[github-actions]

🎉 This PR is included in version 3.4.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[amannn]

@julianpoy Unfortunately this PR has caused a bug (#128) and I had to revert this temporarily.

I think the access to commit.message is invalid, if you look below we were accessing the message like commits[0].commit.message before.

Would you be interested in creating another PR with the change and the fix? The contributors guide has instructions about how you can test this action. Due to the nature of this action we have to rely a bit on manual testing unfortunately and I overlooked to do it.

[julianpoy]

@amannn oh wow, so sorry about that!

Makes sense, will try the fix again following that guide.

Unsure why the commit.message would be invalid for commits mapped. Perhaps merge commits don't include a message field? Oh well, I'll look into it.

[mrchief]

Can confirm - I'm getting Error: Cannot read property 'startsWith' of undefined