feat: upgrade [email protected] #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuatz
force-pushed
the
feat/upgrade-semantic-release
branch
from
1c997c9 to
b2fc056
Compare
amannn
reviewed
Feb 2, 2022
xuatz
force-pushed
the
feat/upgrade-semantic-release
branch
2 times, most recently
from
97f3daa to
9179e5f
Compare
I've added a line, but I'm not sure if I understood your intention or made the right wording ^^ |
amannn
reviewed
Feb 2, 2022
CONTRIBUTORS.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| Thank you very much for contributing to this project! | |||
|
|
|||
| Just a heads up, this project uses node16. | |||
There was a problem hiding this comment.
Sorry, I should have been more precise. I meant if you can add a note at the bottom that the built file should not be included in the PR.
There was a problem hiding this comment.
Changed to add the intended text instead 😆
xuatz
force-pushed
the
feat/upgrade-semantic-release
branch
from
9179e5f to
b3307ec
Compare
|
@xuatz The lockfile changed from your other PR, care to resolve that quickly? 🙂 |
* upgraded to node@16 * https://github.com/semantic-release/semantic-release/releases/tag/v19.0.0 BREAKING CHANGE: dropped support for node <=15
xuatz
force-pushed
the
feat/upgrade-semantic-release
branch
from
b3307ec to
b13c44a
Compare
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
Workflow still works (fails) if the PR title is horrible
Notes
You might not be interested in this PR, but since I'm updating it to fix the "vulnerabilities" to comply with company regulations, I decide to make a PR just in case you want the changes.
Checklist