-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add options to pass custom regex to conventional-commits-parser #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution! The code looks excellent, I only have some minor suggestions for the descriptions in the docs.
What do you think?
Co-authored-by: Jan Amann <[email protected]>
@amannn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you so much! 🙌
As for the options, I feel the GitHub enterprise will be the least used one, but of course I don't have any stats about this and personally when I am reading docs, I usually read all of them.
That could be, yes – but I think we can leave it for now.
🎉 This PR is included in version 4.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Resolves #175
The PR I used for testing:
Jomshir98/action-semantic-pull-request#1