Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options to pass custom regex to conventional-commits-parser #177

Merged
merged 5 commits into from
Apr 22, 2022

Conversation

Jomshir98
Copy link
Contributor

Resolves #175

The PR I used for testing:
Jomshir98/action-semantic-pull-request#1

Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! The code looks excellent, I only have some minor suggestions for the descriptions in the docs.

What do you think?

README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@Jomshir98
Copy link
Contributor Author

@amannn
I fully agree with the points in the review; writing documentation never really was my strong side.
As for the options, I feel the GitHub enterprise will be the least used one, but of course I don't have any stats about this and personally when I am reading docs, I usually read all of them.

Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you so much! 🙌

As for the options, I feel the GitHub enterprise will be the least used one, but of course I don't have any stats about this and personally when I am reading docs, I usually read all of them.

That could be, yes – but I think we can leave it for now.

@amannn amannn merged commit 956659a into amannn:master Apr 22, 2022
@github-actions
Copy link

🎉 This PR is included in version 4.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Jomshir98 Jomshir98 deleted the feat/custom-pattern branch April 22, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Custom regex instead of conventional-commits-parser
2 participants