Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP vs Draft #21

Closed
zeke opened this issue Aug 14, 2020 · 2 comments
Closed

WIP vs Draft #21

zeke opened this issue Aug 14, 2020 · 2 comments

Comments

@zeke
Copy link

zeke commented Aug 14, 2020

Hey @amannn I noticed there's a new feature to support a [WIP] prefix: #3

Did you consider GitHub's draft pull requests feature? Instead of using that WIP prefix, this Action could check whether or not the PR is a draft and react accordingly.

@amannn
Copy link
Owner

amannn commented Aug 16, 2020

Hi @zeke,

yep, that's true. I added the WIP support because it seems like Github has disabled the draft pull request feature for private projects on the free plan.

But for "real" draft pull requests, wouldn't it make sense anyway to already validate the title and to expect the prefixes? Similar to how you also want e.g. your tests to run and potentially fail, even if you don't intend to merge the PR just yet.

For the [WIP] PRs in practice I still use titles like [WIP] feat: Add button and already indicate the release type.

What do you think?

@zeke
Copy link
Author

zeke commented Aug 25, 2020

That seems reasonable 👍🏼

Github has disabled the draft pull request feature for private projects on the free plan.

I did not know that :[

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants