Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node20 support and new release #239

Closed
MikeMcC399 opened this issue Sep 25, 2023 · 3 comments · Fixed by #240
Closed

node20 support and new release #239

MikeMcC399 opened this issue Sep 25, 2023 · 3 comments · Fixed by #240

Comments

@MikeMcC399
Copy link

Current situation

The latest release of this action v5.2.0 runs under the deprecated node16 version of Node.js

runs:
using: 'node16'
main: 'dist/index.js'

Node.js 16 already entered into end-of-life on Sep 11, 2023.

Requested change

Please update the action to run under node20 according to the GitHub announcement GitHub Actions: Transitioning from Node 16 to Node 20 dated Sep 22, 2023.

See also runs for JavaScript actions.

Benefit

According to GitHub's announcement all node16 JavaScript actions will be forced to run under node20 early in 2024. Proactively migrating, testing and releasing a new version of this action gives users the opportunity to migrate earlier than the forced migration and avoids any surprises that may be caused by any otherwise undiscovered incompatibility with node20.

@amannn
Copy link
Owner

amannn commented Sep 25, 2023

Great point, thanks for bringing this up! Would you be interested in setting up a PR with the relevant change?

@MikeMcC399
Copy link
Author

@amannn

Would you be interested in setting up a PR with the relevant change?

Thanks for your interest!

Unfortunately I don't have the history and experience in this repo, so I'm probably not the best person to be submitting a PR for this change. It looks like there are multiple changes which would be necessary and it's not simply a case of changing action.yml to refer to node20 instead of node16. Workflows are also running under the end-of-life Node.js 16 and these should probably be changed as well. It will probably take 6 months before GitHub forces the use of node20, so hopefully that should be enough time to prepare.

@github-actions
Copy link

🎉 This issue has been resolved in version 5.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants