Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global laser phase is missing #13

Open
hongyehu opened this issue Apr 27, 2024 · 2 comments
Open

Global laser phase is missing #13

hongyehu opened this issue Apr 27, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@hongyehu
Copy link

Dear Authors,
Thank you for open source this interesting code. I have been reading the source code, and I feel like the implementation doesn't include the laser phase terms. Is my understanding correct? If so, are you going to implement that any time soon? Many thanks.
@hongyehu
Copy link
Author

If one can confirm the laser phase term is not included, I can try to add it. :-)

@kshyatt-aws kshyatt-aws added the good first issue Good for newcomers label May 14, 2024
@kshyatt-aws kshyatt-aws removed their assignment May 14, 2024
@AbdullahKazi500 AbdullahKazi500 mentioned this issue May 31, 2024
Closed
@AbdullahKazi500
Copy link

@kshyatt-aws added the gLobal phase in the PR #16

This was referenced May 31, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated mps_utils.jl AbdullahKazi500/BraketAHS.jl
3 participants
@hongyehu @kshyatt-aws @AbdullahKazi500