Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically determine dimensions for aq.ArrayVar declaration #13

Closed
rmshaffer opened this issue May 8, 2024 · 2 comments · Fixed by #22
Closed

Automatically determine dimensions for aq.ArrayVar declaration #13

rmshaffer opened this issue May 8, 2024 · 2 comments · Fixed by #22
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rmshaffer
Copy link
Contributor

Today the dimensions kwarg is required when declaring an aq.ArrayVar. For example:

aq.ArrayVar([1, 2, 3], dimensions=[3])

We should be able to automatically infer dimensions if an initial value is defined. So the code becomes just:

aq.ArrayVar([1, 2, 3])

Optionally, we may remove the dimensions kwarg altogether, and force the user to always specify an initial value.

@rmshaffer
Copy link
Contributor Author

@Yash-10, thank you for the contribution! Can you please confirm that you'd like me to assign this issue to you?

@Yash-10
Copy link
Contributor

Yash-10 commented Jun 3, 2024

Thank you @rmshaffer! Sure, I'd like to be assigned to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

2 participants