Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Rust 2018 #568

Closed
torkleyy opened this issue Mar 31, 2019 · 0 comments · Fixed by #575
Closed

Migrate to Rust 2018 #568

torkleyy opened this issue Mar 31, 2019 · 0 comments · Fixed by #575
Labels
easy good first issue Perfect for new contributors ready

Comments

@torkleyy
Copy link
Member

Let's move to the new edition finally!

This will require to bump the minimum version in the README and .travis.yml; let's bump to Rust 1.32 which is required for shred anyways.
@torkleyy torkleyy added easy ready good first issue Perfect for new contributors labels Mar 31, 2019
torkleyy added a commit to torkleyy/specs that referenced this issue Apr 18, 2019
@torkleyy
Migrate to Rust 2018
419efe4 
Fixes amethyst#568
@torkleyy torkleyy mentioned this issue Apr 18, 2019
Merged
4 tasks
bors bot added a commit that referenced this issue Apr 18, 2019
@bors @torkleyy
Merge #575
7bd3a76 
575: Cleanup the whole crate r=torkleyy a=torkleyy

<!-- Before creating a PR, please make sure you read the contribution guidelines. -->
<!-- Feel free to delete points if they don't make sense for this PR. -->
<!-- You can tick boxes by putting an "x" inside the braces, or by clicking them once the comment is published. -->

<!-- Please use "Fixes #nr" and "Related #nr", respectively. -->

## Checklist

* [x] I've added tests for all code changes and additions (where applicable)
* [x] I've added a demonstration of the new feature to one or more examples
* [x] I've updated the book to reflect my changes
* [x] Usage of new public items is shown in the API docs

## API changes

No direct API changes.

## Issues

Fixes #568



Co-authored-by: Thomas Schaller <[email protected]>
@bors bors bot closed this as completed in #575 Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy good first issue Perfect for new contributors ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup the whole crate torkleyy/specs
1 participant
@torkleyy