Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration documentation incorrect #237

Closed
michael-wolfenden opened this issue Feb 25, 2016 · 4 comments
Closed

Migration documentation incorrect #237

michael-wolfenden opened this issue Feb 25, 2016 · 4 comments

Comments

@michael-wolfenden
Copy link
Contributor

The isomorph apps section of the migration document states that you can still use a javascript functions to generate a template by declaring a function with the following signature

function(compilationResult, chunks, assets, compilation) {
...
};

This is incorrect, the actual signature is:

function (templateParams) {
...
}

Also, this new function is not a complete replacement for templateContent as we no longer have access to the compilation object as it not available from templateParams.

The old signature was:

function (templateParams, compilation, callback) {
...
}

Could the compilation property be added to templateParams?

@jantimon
Copy link
Owner

Yes sure why not - could you add a pull request with a unit test?

@michael-wolfenden
Copy link
Contributor Author

Any ideas when a new release will be released?

@jantimon
Copy link
Owner

Released as 2.10.0

@lock
Copy link

lock bot commented Jun 1, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants