Function Redeclaration in */functions.php Due to Missing Safety Guards

[ghostwriter]

Hi,

I'm experiencing an issue with a tool that relies on this package.

The problem occurs when the tool tries to include vendor/autoload.php which automatically includes these functions via composer.

amp/composer.json

Lines 48 to 52 in 138801f

	"files": [
	"src/functions.php",
	"src/Future/functions.php",
	"src/Internal/functions.php"
	]

It results in a "previously declared" function error due to a lack of safety guards to check if the function already exists.

Here is a screenshot illustrating the issue:

---

Suggested Fix:

Add a safety guard to the functions to prevent redeclaration, like:

if (! \function_exists('functionName')) {
    // function definition here
}

Thank you for your time.

[Bilge]

How do you wilfully end up with two definitions for \Amp\delay, and why do you believe it's correct to do so?

[ghostwriter]

@Bilge I was using "master" branch of psalm, (globally installed via composer because i need the new version of php-parser for a psalm plugin).

Composer is autoloading the global autoload file , ~/.composer/vendor/autoload.php and local autoload file ~/Desktop/oss/ghostwriter/atprotocol/vendor/autoload.php.

If the guard was there, it would work without any issues.

[rela589n]

@ghostwriter , I also faced this same issue when using psalm. From my side, the solution was moving it into vendor-bin (by means of composer bin plugin) and installing it there. Also, there (in vendor-bin) I patched (composer patches) amp library in order to not re-declare function if it was already declared. Finally, I had to define custom boostrap.php file to first include my main project autoload.php file and only then autoload of vendor-bin directory.

See https://github.com/rela589n/knowledge-base/blob/main/PHP/Psalm%20in%20a%20separate%20composer.json.md

[kelunik]

@rela589n It very much sounds like you're fighting the symptom instead of the root cause.

Two different versions of the library might lead to issues, adding the guard would just hide the symptom.

I highly recommend to use the psalm phar, like all amphp projects do.

[rela589n]

@kelunik , as far as I remember I could not have managed to get it working correctly when running from phar either because of this same problem of already declared function.

Maybe you have tried doing this with the different outcome?

[kelunik]

All our packages use Psalm and we've never had this problem. You can have a look at the CI config for GitHub actions to compare it to your setup.

[ghostwriter]

Hey @rela589n Thank you, we will try your solution. 🙏🏾 I appreciate you not being dismissive and condescending. ❤️

---

NOTE:

• We are NOT trying to "just run" Psalm

• We need the unreleased code on the master branch to implement a specific feature, Psalm needs to be installed and autoloaded for Psalm plugins to work properly.

• We DO NOT want or need the Psalm.phar

  • How to use psalm/phar with psalm plugins? psalm/phar#3
  • Conflict with vimeo/psalm prohibits the installation of plugins psalm/phar#14
  • Call to undefined method Psalm\Config::getConfigForPath() Psalm 5.23.0 psalm/phar#17
  • https://phpc.social/@ramsey/109752634923665153
  • https://phpc.social/@ramsey/109752751603853019
  • https://phpc.social/@ramsey/109753521483645731

Unrelated: I had previously attempted to use the Psalm Phar but encountered issues, particularly because the version compatible with PHP-Parser v5 only exists on the master branch.

[trowski]

I'm confused as to how Psalm 5.x was installed along side Amp 3.x. Composer should not be allowing this, since Psalm 5.x requires Amp 2.x.

Could you explain more about your set up and how there are seemingly two versions of Amp installed simultaneously?

[ghostwriter]

I’ve resolved this issue for myself using ghostwriter/handrail.

Special thanks to @rela589n for the inspiration.

Feel free to keep this issue open if you’d like to explore further.

I’ll be unsubscribing as I’m no longer being blocked by this issue.

Thanks!

---

Goal

Integrate [email protected] and [email protected] (aka psalm@master) in a psalm-plugin package that requires nikic/[email protected].

Notes

• Version Compatibility:

  • [email protected] (aka psalm@master) requires amphp/amp version 3.x.
  • [email protected] requires amphp/amp version 2.x.

• Dependencies:

  • [email protected] (aka psalm@master) has a direct dependency on nikic/php-parser version 5.x.
  • [email protected] has a direct dependency on nikic/php-parser version 4.x.
  • [email protected] indirectly depends on nikic/php-parser version 5.x through phpunit/php-code-coverage.