-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMP Stories] Add any missing features necessary for templates #2013
Comments
Based on the template designs the following features seem to be missing:
|
Color Fill block: My immediate thought was WordPress/gutenberg#4900. The PR for that, WordPress/gutenberg#13964, is still in the works, but according to the comments there it might be ready soon. |
Should be as easy as setting |
What about adding opacity to a block as a whole, and not just the background color? I know this was done for layers in the previous incarnation of AMP Stories. Maybe that is just asking for trouble. |
Unless there is a reason why not to then seems like we could add it generally for other blocks, too, or at least to Image and Text Block. Another style-related thing that occurs frequently in the templates is having rounded corners for images and Text blocks with background color. Maybe that'd also be something necessary? |
It would indeed be useful if background colors everywhere in Gutenberg had the ability to specify the opacity. It's not currently provided normal Color Settings: The Overlay has the opacity as a separate slider for Background Opacity as shown above: By it would be cool if all color pickers just had opacity as a standard parameter.
Oh yeah, a border radius setting for the text block and image block would be very nice! |
Ticket description is now updated based on the discussion. |
Could this be a block style instead? Then one could choose between "Default" and "Rounded" without having to worry about the block radius always being consistent between blocks. Or is there a strong use case for a block radius range control? |
"Default" and "Rounded" should be sufficient, we can adjust later if it should become necessary. |
Will start working on adding the gradient/scrim setting to Page. cc @swissspidy |
verified in QA |
AC: All the features needed for the templates exist.
AC: User can set border radius to Image and Text blocks via block style (accessible via block style button in the left top corner of the block, or in the right sidebar in the block settings.
AC: User can align the text in Text block.
AC: User can add a gradient to the Page block.
Features needed:
Add opacity Range control to allowed (child) blocks which use background color.Moved to a separate issue: #2058The text was updated successfully, but these errors were encountered: