Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update block editor package #3149

Merged
merged 5 commits into from
Sep 3, 2019
Merged

Update block editor package #3149

merged 5 commits into from
Sep 3, 2019

Conversation

swissspidy
Copy link
Collaborator

Supersedes #3123.

@swissspidy swissspidy added the Infrastructure Changes impacting testing infrastructure or build tooling label Aug 30, 2019
@swissspidy swissspidy added this to the v1.3 milestone Aug 30, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Aug 30, 2019
@swissspidy swissspidy mentioned this pull request Aug 30, 2019
Closed
1 task
barklund
barklund reviewed Aug 30, 2019
View reviewed changes
package.json Show resolved Hide resolved
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Has not signed the Google CLA and removed cla: yes Signed the Google CLA labels Aug 30, 2019
@miina
Copy link
Contributor

miina commented Aug 30, 2019

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Aug 30, 2019
spacedmonkey
spacedmonkey approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miina
Copy link
Contributor

miina commented Sep 3, 2019

Merging develop once more for the tests to run just in case.

@miina miina merged commit 84dd371 into develop Sep 3, 2019
@miina miina deleted the update/block-editor-package branch September 3, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barklund barklund barklund left review comments

@spacedmonkey spacedmonkey spacedmonkey approved these changes

@miina miina Awaiting requested review from miina

@dero dero Awaiting requested review from dero

Assignees
No one assigned
Labels
cla: yes Signed the Google CLA Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@swissspidy @googlebot @miina @spacedmonkey @barklund