Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid duplicate headers #17

Merged
merged 6 commits into from
Jan 24, 2024
Merged

fix: Avoid duplicate headers #17

merged 6 commits into from
Jan 24, 2024

Conversation

geoffreyfourmis
Copy link
Contributor

Sorry my last PR introduce a CORS error on nested resource (like memberships) due to duplicate headers :

image

It's because setup() should be run only once per request

@geoffreyfourmis geoffreyfourmis marked this pull request as draft January 20, 2024 03:46
@geoffreyfourmis geoffreyfourmis marked this pull request as ready for review January 20, 2024 04:36
Copy link
Owner

@anarsultanov anarsultanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I missed that too 👍

@anarsultanov anarsultanov changed the title Avoid duplicate headers fix: Avoid duplicate headers Jan 20, 2024
@anarsultanov anarsultanov merged commit d461384 into anarsultanov:main Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants