Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly test PURL generation against key packages #2071

Closed
willmurphyscode opened this issue Aug 28, 2023 · 1 comment
Closed

Explicitly test PURL generation against key packages #2071

willmurphyscode opened this issue Aug 28, 2023 · 1 comment
Assignees
Labels
ecosystem:java relating to the java ecosystem enhancement New feature or request testing

Comments

@willmurphyscode
Copy link
Contributor

What would you like to be added:

During the last syft release (v.0.88.0), we did a fair amount of manual testing of package url (PURL) generation during the release process, and this caught some regressions that would otherwise have been released. The ask here is to put automated testing in syft to assert that syft generates the correct set of PURLs off some known test images, especially images that have JARs in them, since that is the ecosystem where we caught the regressions.

A simple implementation might be: add some Java test images to or JARs to the test fixtures, and then add an integration test that asserts that these new test fixtures generate a correct set of PURLs.

Why is this needed:

GHSAs are a great source for data about vulnerabilities, but matching against them depends on generating correct PURLs.

@willmurphyscode willmurphyscode added enhancement New feature or request ecosystem:java relating to the java ecosystem testing labels Aug 28, 2023
@willmurphyscode willmurphyscode self-assigned this Aug 29, 2023
@willmurphyscode
Copy link
Contributor Author

Fixed by #2075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem:java relating to the java ecosystem enhancement New feature or request testing
Projects
None yet
Development

No branches or pull requests

1 participant