Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems when executors from ext/types threw exceptions #67

Closed
rafaelverger opened this issue Nov 22, 2017 · 1 comment
Closed

Problems when executors from ext/types threw exceptions #67

rafaelverger opened this issue Nov 22, 2017 · 1 comment

Comments

@rafaelverger
Copy link
Contributor

Exceptions thrown by ext/types are being imported based on a different object compared with the expected exceptions in core/controller.ts;

For example when StringSearch receives an empty result from server it throws a ValidatorError extracted from YveBot.exceptions and then controller tries to analyse it by checking if it is an instance of ValidatorError from module ./exceptions. This check results in a fail and then the bot get stuck :/

@rafaelverger
Copy link
Contributor Author

This error was the reason of #44 :/ so the PR #64 could be reverted since it will cover an "impossible" situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant