Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isort check in CI #76

Open
andrenarchy opened this issue Apr 26, 2020 · 4 comments
Open

Add isort check in CI #76

andrenarchy opened this issue Apr 26, 2020 · 4 comments
Assignees

Comments

@andrenarchy
Copy link
Owner

Analogous to the linter, we should add an isort check to the workflow file.

@nschloe
Copy link
Contributor

nschloe commented Apr 26, 2020

And black. Assigning myself.

@andrenarchy
Copy link
Owner Author

Black is already in there.

@nschloe
Copy link
Contributor

nschloe commented Apr 26, 2020

Ah yes. Well, isort and black are a little complicated (they contradict each other in minor details), see PyCQA/isort#694, psf/black#333. I usually skip isort checks on CI. I haven't looked at this for a while so there may be a convenient solution by now.

@andrenarchy
Copy link
Owner Author

Ah I see. Let me know if it does work. Otherwise, we can skip isort for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants