-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pyproject.toml to be located in root dir's parents #21
Conversation
Hi @michael-k, thanks for the pull request. Is your project structure like this?
Just understanding the case, so a specific test can be written later. |
Yeah, but |
Thanks again, I will release a new version in the coming days. |
Hi @michael-k. a. together with |
We don't have a I'll try to look into it later today. Maybe I can provide a minimal example. |
I can confirm that it did not work with my change, but works with yours. :) |
Nice. :) I assumed answer "a", Is this a common Django project structure ( |
I'm not sure if it's best practice to put pyproject.toml in same directory as manage.py or not. I'm not aware of any other django project that uses a pyproject.toml (we only started using it when we introduced black and nitpick is second tool we use it for). |
# [0.11.0](v0.10.3...v0.11.0) (2019-03-31) ### Features * allow pyproject.toml to be located in root dir's parents (thanks [@michael-k](https://github.com/michael-k)) ([#21](#21)) ([d3c4d74](d3c4d74))
🎉 This PR is included in version 0.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
I'm also not sure about Django best practices. |
In our projects the
root_dir
is where django'smanage.py
lives, butpyproject.toml
lives inroot_dir.parent
.