You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried the text plugin to check a yaml file using this style
[[".gitlab-ci.yml".contains]]
line = " - mypy -p ims --junit-xml report-mypy.xml"
[[".gitlab-ci.yml".contains]]
line = " - apache-license-check --copyright \"2019-2020 SURF\" ims"
[[".gitlab-ci.yml".contains]]
line = " - flake8 --tee --output-file flake8.txt; exit_code=$?; flake8_junit flake8.txt report-flake8.xml"
[[".gitlab-ci.yml".contains]]
line = " - if [ $exit_code -ne 0 ]; then exit 1; fi;"
[[".gitlab-ci.yml".contains]]
line = " - isort -c ims"
[[".gitlab-ci.yml".contains]]
line = " - black --check ."
[[".gitlab-ci.yml".contains]]
line = " - pytest --cov=ims --cov-branch --junitxml=report-pytest-unit.xml --cov-fail-under="
Current Behavior
It fails because the text plugin only accepts plain-text files and thus it gives an error about files not being configured correctly
Expected Behavior
I expect the text plugin to always work (maybe even with binary files) since it provides an escape hatch for unsupported formats or weird files where inspect might do the wrong thing
Your Environment
nitpick version used: Latest
Python version: 3.8
Operating System and version: Ubuntu 20.04
The text was updated successfully, but these errors were encountered:
I saw this problem before...
For some reason I'm still not sure, using text instead of plain-text breaks a lot of tests: d179976
The current logic is not prepared to deal with a file that can be handled by multiple plugins.
YAML, TOML and JSON are also text files; the Text plugin is trying to process these files as well, and it's failing.
I expect the text plugin to always work (maybe even with binary files) since it provides an escape hatch for unsupported formats or weird files where inspect might do the wrong thing
I would like this feature myself.
But I'm afraid that solving this problem will be more complicated than I would like to.
The logic needs a good dose of refactoring to handle this case.
Expected Behavior
I tried the text plugin to check a yaml file using this style
Current Behavior
It fails because the text plugin only accepts
plain-text
files and thus it gives an error about files not being configured correctlyExpected Behavior
I expect the text plugin to always work (maybe even with binary files) since it provides an escape hatch for unsupported formats or weird files where inspect might do the wrong thing
Your Environment
nitpick
version used: LatestPython version: 3.8
Operating System and version: Ubuntu 20.04
The text was updated successfully, but these errors were encountered: