Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keys suggested in the order they are defined #442

Merged
merged 6 commits into from
Jan 15, 2022

Conversation

andreoliwa
Copy link
Owner

@andreoliwa andreoliwa commented Jan 15, 2022

Proposed changes

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for the relevant parts:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's a new API or functionality

@coveralls
Copy link

coveralls commented Jan 15, 2022

Pull Request Test Coverage Report for Build 1700476773

  • 77 of 78 (98.72%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 97.019%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/nitpick/blender.py 49 50 98.0%
Files with Coverage Reduction New Missed Lines %
src/nitpick/blender.py 1 96.68%
Totals Coverage Status
Change from base Build 1696026181: -0.01%
Covered Lines: 1987
Relevant Lines: 2031

💛 - Coveralls

Positive side effect: the suggestion of initial contents now displays
the keys in the order they were defined in the TOML file,
and not in alphabetical order anymore.
Dicts are already ordered in Python 3.7
@andreoliwa andreoliwa marked this pull request as ready for review January 15, 2022 02:36
@andreoliwa andreoliwa changed the title refactor: add flatten-dict and dpath fix: keys suggested in the order they are defined Jan 15, 2022
@andreoliwa andreoliwa merged commit 09c30ab into develop Jan 15, 2022
@andreoliwa andreoliwa deleted the add-flatten-dict-dpath branch January 15, 2022 02:56
github-actions bot pushed a commit that referenced this pull request Jan 15, 2022
# [0.31.0](v0.30.0...v0.31.0) (2022-01-15)

### Bug Fixes

* keys suggested in the order they are defined ([#442](#442)) ([09c30ab](09c30ab))
* pin attrs to >=20.1.0, change imports ([0696d08](0696d08))

### Features

* drop support for Python 3.6 ([#439](#439)) ([a02e0ce](a02e0ce))
@github-actions
Copy link

🎉 This PR is included in version 0.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Feature/fix is released label Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Feature/fix is released
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants