Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: actually show chosen styles in log output #477

Merged
merged 2 commits into from
Mar 28, 2022
Merged

fix: actually show chosen styles in log output #477

merged 2 commits into from
Mar 28, 2022

Conversation

mjpieters
Copy link
Contributor

There were two issues with the log output:

  • It always claimed the configured styles came from pyproject.toml even when
    .nitpick.toml is actually used.
  • The chosen styles were shown as <more_itertools.more.peekable object at 0x[hex address]>

Checklist

  • Read the contribution guidelines
  • Run make locally before pushing commits
  • Add tests for the relevant parts:
    • API
    • CLI
    • flake8 plugin (normal mode)
    • flake8 plugin (offline mode)
  • Write documentation when there's a new API or functionality

@mjpieters
fix: actually show chosen styles in log output
cc78cfc 
There were two issues with the log output:

- It always claimed the configured styles came from pyproject.toml even when
  .nitpick.toml is actually used.
- The chosen styles were shown as `<more_itertools.more.peekable object at 0x[hex address]>`
andreoliwa
andreoliwa approved these changes Mar 28, 2022
View reviewed changes
Copy link
Owner

@andreoliwa andreoliwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on fire. 🔥 😅 🙏🏻

src/nitpick/style/core.py Show resolved Hide resolved
src/nitpick/project.py Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2055084544

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.45%
Totals Coverage Status
Change from base Build 2054898668: 0.0%
Covered Lines: 2017
Relevant Lines: 2073
💛 - Coveralls

@andreoliwa andreoliwa merged commit 9a685ac into andreoliwa:develop Mar 28, 2022
@mjpieters mjpieters deleted the configed_styles_logging branch March 28, 2022 22:46
This was referenced Mar 24, 2023
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Closed
github-actions bot pushed a commit that referenced this pull request Mar 27, 2023
@semantic-release-bot
chore(release): 0.33.0 [skip ci]
2148c86 
# [0.33.0](v0.32.0...v0.33.0) (2023-03-27)

### Bug Fixes

* actually show chosen styles in log output ([#477](#477)) ([9a685ac](9a685ac))
* **deps:** update dependency attrs to v22 ([d3ad0e0](d3ad0e0))
* **deps:** update dependency click to v8.1.3 ([bd54df5](bd54df5))
* **deps:** update dependency configupdater to v3.1.1 ([024fd16](024fd16))
* **deps:** update dependency dpath to v2.1.5 ([#557](#557)) ([6a4fddd](6a4fddd))
* **deps:** update dependency flake8 to v5 ([#559](#559)) ([1bc7b06](1bc7b06))
* **deps:** update dependency freezegun to v1.2.2 ([#543](#543)) ([9a67f5a](9a67f5a))
* **deps:** update dependency identify to v2.5.22 ([00dbdce](00dbdce))
* **deps:** update dependency importlib-resources to v5.12.0 ([68aae5c](68aae5c))
* **deps:** update dependency jmespath to v1 ([e51c957](e51c957))
* **deps:** update dependency marshmallow to v3.19.0 ([a314480](a314480))
* **deps:** update dependency marshmallow-polyfield to v5.11 ([#545](#545)) ([b05092b](b05092b))
* **deps:** update dependency more-itertools to v8.14.0 ([#531](#531)) ([139ef6b](139ef6b))
* **deps:** update dependency pytest to v7 ([a080454](a080454))
* **deps:** update dependency pytest-cov to v4 ([db278d4](db278d4))
* **deps:** update dependency pytest-datadir to v1.4.1 ([c6d5cb4](c6d5cb4))
* **deps:** update dependency pytest-socket to v0.6.0 ([#534](#534)) ([2bdf0d6](2bdf0d6))
* **deps:** update dependency pytest-testmon to v1.4.5 ([392fce5](392fce5))
* **deps:** update dependency pytest-testmon to v2.0.1 ([81b300d](81b300d))
* **deps:** update dependency pytest-testmon to v2.0.2 ([1e58ff2](1e58ff2))
* **deps:** update dependency python-slugify to v8 ([77649bd](77649bd))
* **deps:** update dependency requests to v2.28.2 ([#536](#536)) ([0af1b14](0af1b14))
* **deps:** update dependency requests-cache to v0.9.8 ([#518](#518)) ([2135344](2135344))
* **deps:** update dependency requests-cache to v1.0.1 ([2104255](2104255))
* **deps:** update dependency responses to v0.23.1 ([#537](#537)) ([796034c](796034c))
* **deps:** update dependency sphinx to v4.5.0 ([#538](#538)) ([aee2267](aee2267))
* **deps:** update dependency sphinx to v5 ([#560](#560)) ([b7fcb67](b7fcb67))
* **deps:** update dependency sphinx_rtd_theme to v1.2.0 ([f729818](f729818))
* **deps:** update dependency sphobjinv to v2.3.1 ([33bea38](33bea38))
* **deps:** update dependency strenum to v0.4.10 ([4aed308](4aed308))
* **deps:** update dependency testfixtures to v6.18.5 ([311a5ca](311a5ca))
* **deps:** update dependency tomlkit to v0.11.6 ([a28e6d7](a28e6d7))
* document.add does not work on Linux ([#487](#487)) ([07048bb](07048bb))
* further improve file path handling ([#479](#479)) ([6cff555](6cff555))
* pass in token to fetch GH default branch ([#475](#475)) ([46ea598](46ea598))

### Features

* add MegaLinter plugin ([#476](#476)) ([212a36a](212a36a))
* add Python 3.11 ([2a7cbea](2a7cbea))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreoliwa andreoliwa andreoliwa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjpieters @coveralls @andreoliwa