Ordering is inconsistently determined

[jgolieb]

The order of formPanels, questionSets, and questions seems to be inconsistent. Questions are ordered by their array order. QuestionSets, seem to be controlled by their array order in the questionPanels.questionSets array as well, rather than by the index property shown in the examples. As for formPanels, looking at the code, I find that they do get sorted by their index property (index.js line 21).

This is inconsistent, but may be intentional for some reason. If so, the index property of the questionSet should be omitted from documentation as it is misleading and never used. Personally, I'd rather see the ordering of everything be based on the actual array order rather then an index property. However, it could also be configurable, or index could be used if present with fallback to array order. Most importantly, this should be implemented consistently.

[andrewhathaway]

Hi @jgolieb, apologies for the late response. You are correct in this one, form panels are ordered by their index. However, other indexes are used as IDs essentially, this may be an oversight. As the indexes are actually valuable, ideally they'd all be ordered by an index.