Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] enable all button variations to work in button-group #112

Closed
wants to merge 1 commit into from
Closed

[fix] enable all button variations to work in button-group #112

wants to merge 1 commit into from

Conversation

designsaves
Copy link
Contributor

@designsaves designsaves commented Jun 21, 2017 •
edited
Loading

Fixes #102

@designsaves
Copy link
Contributor Author

designsaves commented Jun 21, 2017 •
edited
Loading

Previously, button-disabled, button-outlined-<type>, and button-<size> didn't work well within button groups. This fixes that.

I also updated the button examples in the docs to all be button elements rather than a tags for consistency - with the exception of one example which is specifically called out.

@lynnandtonic
Copy link
Contributor

Looks great! 👍

@designsaves designsaves mentioned this pull request Apr 16, 2018
Merged
@designsaves
Copy link
Contributor Author

Merged into this new PR: #118

@lynnandtonic lynnandtonic deleted the button-outlined-group branch May 23, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@designsaves @lynnandtonic