Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge changes from nathanmarz/storm master #16

Merged
merged 17 commits into from
Aug 21, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
* FixedBatchSpout will now replay batches appropriately on batch failure (thanks ptgoetz)
* Can set JAR_JVM_OPTS env variable to add jvm options when calling 'storm jar' (thanks srmelody)
* Throw error if batch id for transaction is behind the batch id in the opaque value (thanks mrflip)
* Sort topologies by name in UI (thanks jaked)
* Added LoggingMetricsConsumer to log all metrics to a file, by default not enabled (thanks mrflip)
* Add prepare(Map conf) method to TopologyValidator (thanks ankitoshniwal)
* Bug fix: Supervisor provides full path to workers to logging config rather than relative path (thanks revans2)
* Bug fix: Call ReducerAggregator#init properly when used within persistentAggregate (thanks lorcan)
* Bug fix: Set component-specific configs correctly for Trident spouts
Expand Down
2 changes: 2 additions & 0 deletions README.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ You must not remove this notice, or any other, from this software.
* Tudor Scurtu ([@tscurtu](https://github.com/tscurtu))
* Homer Strong ([@strongh](https://github.com/strongh))
* Sean Melody ([@srmelody](https://github.com/srmelody))
* Jake Donham ([@jaked](https://github.com/jaked))
* Ankit Toshniwal ([@ankitoshniwal](https://github.com/ankitoshniwal))

## Acknowledgements

Expand Down
1 change: 1 addition & 0 deletions storm-core/src/clj/backtype/storm/daemon/nimbus.clj
Original file line number Diff line number Diff line change
Expand Up @@ -877,6 +877,7 @@
(.prepare inimbus conf (master-inimbus-dir conf))
(log-message "Starting Nimbus with conf " conf)
(let [nimbus (nimbus-data conf inimbus)]
(.prepare ^backtype.storm.nimbus.ITopologyValidator (:validator nimbus) conf)
(cleanup-corrupt-topologies! nimbus)
(doseq [storm-id (.active-storms (:storm-cluster-state nimbus))]
(transition! nimbus storm-id :startup))
Expand Down
4 changes: 2 additions & 2 deletions storm-core/src/clj/backtype/storm/ui/core.clj
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@
(.get_num_executors t)
(.get_num_tasks t)
])
:time-cols [2]
:sort-list "[[2,1]]"
:time-cols [3]
:sort-list "[[0,0]]"
))

(defn supervisor-summary-table [summs]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
import java.util.Map;

public class DefaultTopologyValidator implements ITopologyValidator {
@Override
public void prepare(Map StormConf){
}
@Override
public void validate(String topologyName, Map topologyConf, StormTopology topology) throws InvalidTopologyException {
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import java.util.Map;

public interface ITopologyValidator {
void prepare(Map StormConf);
void validate(String topologyName, Map topologyConf, StormTopology topology)
throws InvalidTopologyException;
}