Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation of empty required node shows misplaced diagnostics #145

Closed
fbricon opened this issue Sep 25, 2018 · 2 comments
Closed

Validation of empty required node shows misplaced diagnostics #145

fbricon opened this issue Sep 25, 2018 · 2 comments
Labels
bug Something isn't working validation
Milestone
v0.0.2

Comments

@fbricon
Copy link
Contributor

fbricon commented Sep 25, 2018

With the same old invoice document, when adding empty tags that are required, the diagnostics are put under the closing bracket. Also the 1st empty tag is underline:
sep-25-2018 18-09-12
@fbricon fbricon added bug Something isn't working validation labels Sep 25, 2018
angelozerr added a commit that referenced this issue Sep 26, 2018
@angelozerr
Select start tag when none text to select (see #145)
90bd091
@angelozerr
Copy link
Contributor

@fbricon please tell me if it's OK now.

@fbricon
Copy link
Contributor Author

fbricon commented Sep 26, 2018

Works fine now, thanks @angelozerr

@fbricon fbricon closed this as completed Sep 26, 2018
@fbricon fbricon added this to the v0.0.2 milestone Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working validation
Projects
None yet
Milestone
v0.0.2
Development

No branches or pull requests
2 participants
@fbricon @angelozerr