Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CacheResourcesManager keeps trying to download unavailable resources #201

Closed
fbricon opened this issue Nov 7, 2018 · 4 comments
Closed

CacheResourcesManager keeps trying to download unavailable resources #201

fbricon opened this issue Nov 7, 2018 · 4 comments
Assignees
@NikolasKomonen
Labels
completion This issue or enhancement is related to completion support enhancement New feature or request validation
Milestone
v0.3.0

Comments

@fbricon
Copy link
Contributor

fbricon commented Nov 7, 2018

When a non existing schema is used, CacheResourcesManager will keep on hitting the bad url on every keystroke.

Failed caching queries should be cached themselves (5 minutes?), so as to avoid unnecessary http requests.
@fbricon fbricon added enhancement New feature or request completion This issue or enhancement is related to completion support validation labels Nov 7, 2018
@fbricon fbricon added this to the v0.0.3 milestone Nov 7, 2018
@fbricon fbricon added the to do label Nov 15, 2018
@fbricon
Copy link
Contributor Author

fbricon commented Dec 7, 2018 •
edited
Loading

I'd use caffeine for any time-based caching mechanism.

@angelozerr
Copy link
Contributor

@fbricon is there any chance that you work on this issue? I'm very busy with DTD support issues.

@fbricon
Copy link
Contributor Author

fbricon commented Dec 7, 2018

@NikolasKomonen can look into it once he's done with his stuff

@fbricon fbricon assigned NikolasKomonen and unassigned angelozerr Dec 7, 2018
@angelozerr
Copy link
Contributor

Great! Thanks

NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 3, 2019
@NikolasKomonen
Cache unavailable URI's
50b163f 
Fixes eclipse-lemminx#201

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 4, 2019
@NikolasKomonen
Cache unavailable URI's
75f780f 
Fixes eclipse-lemminx#201

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 4, 2019
@NikolasKomonen
Cache unavailable URI's
817885c 
Fixes eclipse-lemminx#201

Tests aren't complete, need to find a way to handle exceptions.

Signed-off-by: Nikolas Komonen <[email protected]>
@NikolasKomonen NikolasKomonen mentioned this issue Jan 7, 2019
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 7, 2019
@NikolasKomonen
Cache unavailable URI's
fa11d05 
Fixes eclipse-lemminx#201

Tests aren't complete, need to find a way to handle exceptions.

Signed-off-by: Nikolas Komonen <[email protected]>
@NikolasKomonen NikolasKomonen added the needs tests This issue is probably fixed but needs regression tests label Jan 9, 2019
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 9, 2019
@NikolasKomonen
Cache unavailable URI's
3821fef 
Fixes eclipse-lemminx#201

Tests aren't complete, need to find a way to handle exceptions.

Signed-off-by: Nikolas Komonen <[email protected]>
@fbricon fbricon added in progress and removed to do labels Jan 9, 2019
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 25, 2019
@NikolasKomonen
Cache unavailable URI's
0abf22c 
Fixes eclipse-lemminx#201

Signed-off-by: Nikolas Komonen <[email protected]>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 25, 2019
@NikolasKomonen
Cache unavailable URI's
55078ec 
Fixes eclipse-lemminx#201

Signed-off-by: Nikolas Komonen <[email protected]>
fbricon pushed a commit that referenced this issue Jan 25, 2019
@NikolasKomonen @fbricon
Cache unavailable URI's
1725db2 
Fixes #201

Signed-off-by: Nikolas Komonen <[email protected]>
@fbricon fbricon removed in progress needs tests This issue is probably fixed but needs regression tests labels Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolasKomonen NikolasKomonen

Labels
completion This issue or enhancement is related to completion support enhancement New feature or request validation
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
3 participants
@fbricon @angelozerr @NikolasKomonen