Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import errors when there both rzslider.css and rzslider.scss in dist folder #477

Closed
orochies opened this issue Dec 8, 2016 · 7 comments
Closed
Labels

Comments

@orochies
Copy link

orochies commented Dec 8, 2016

I recently cloned my project to a system with macOsx all fine until I ran the command:

sudo npm install

And I see a bug related to sass:

Message:
src/scss/index.scss
Error: It's not clear which file to import for '@import "node_modules/angularjs-slider/dist/rzslider"'.
Candidates:
node_modules/angularjs-slider/dist/rzslider.scss
node_modules/angularjs-slider/dist/rzslider.css
Please delete or rename all but one of these files.
on line 26 of src/scss/index.scss

@import "node_modules/angularjs-slider/dist/rzslider"; // explicit extension o

In my src/scss/index.scss:

@import "node_modules/angularjs-slider/dist/rzslider";

related info: sass/node-sass#1222

I see that it is related to its wonderful module and I come to check version changes and I find a change that says:

5.8.3 (2016-11-03)
Improvement
Generate a SCSS file (simple copy of the css file) in the dist folder so it can be imported (# 449)

-When clone and install angularjs-slider update to v5.8.7
-in the main project (Windows 8) have angularjs-slider v5.5.0

ok v5.8.3 is my problem, solution install v5.8.2 but i lost the last improvements.

Can you move rzslider.scss to src folder?

Thanks.

@ValentinH
Copy link
Member

Actually, I didn't really want to add a .scss version of the .less file... Having it in the src file isn't find either. I think that I will simply remove it, would it fix your issue?

@orochies
Copy link
Author

orochies commented Dec 8, 2016

Yes that will solve my problem, I can update to v5.8.2 without incident.

Look this: sass/libsass#754

@ValentinH
Copy link
Member

I have contacted the person who did the change to see if your solution could match hee needs.

@ronnyrin
Copy link
Contributor

You can easily resolve this issue by specify the extension:
@import "node_modules/angularjs-slider/dist/rzslider.scss

@orochies
Copy link
Author

Okay, I upgraded to 5.9.0 and I've explicitly added the .scss extension on the import line of my index.scss file and now it works on win8 and mac.

In http://sass-lang.com/guide section import say:

When you import a file you don't need to include the file extension .scss. Sass is smart and will figure it out for you. When you generate the CSS you'll get.

I think in these cases if you have to be explicit.

Thanks.

@varunwinni
Copy link

Hi All, I am implementing Rzslider for time range But I am facing some issues. And I already ask in stackoverflow Please look at this. https://stackoverflow.com/questions/45429746/dont-lose-previous-position-of-rzslider-after-select-the-date-in-angular-js?noredirect=1#comment77835931_45429746

@ValentinH
Copy link
Member

Please don't pollute all the previous issues thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants