Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Tagging Broken in 0.12 (including in the demo) #1006

Open
kimardenmiller opened this issue Jun 11, 2015 · 8 comments
Open

Tagging Broken in 0.12 (including in the demo) #1006

kimardenmiller opened this issue Jun 11, 2015 · 8 comments

Comments

@kimardenmiller
Copy link

Anyone else seeing Tagging without multiple broken in 0.12?

In 0.11.1 I see:
image
image
Plunker of 0.11.1 Demo

But in 0.12 I see nothing happening:
image

Plunker from the readme.rd

@r00tat
Copy link

r00tat commented Jun 17, 2015

Got the same in 0.12!

If you add multiple to "Tagging without multiple" part it works!

@kimardenmiller
Copy link
Author

@r00tat, Interesting, but that also changes the UI to make users think it takes multiples, which is not correct for an app that does not take multiples.
image

@jjchiw
Copy link

jjchiw commented Jun 29, 2015

Hi

I've the same problem with tagging without multiples in version 0.11.2 and 0.12 I was looking at the code and it seems the keyput listener $select.searchInput.on('keyup', function(e) { it's only on the directive uiSelectMultipleand not in uiSelectSingle neither in uiSelect

I moved that part of the code to uis.directive('uiSelect', and it seems it works with multiple and without multiple.....(shows the tagging-label in the dropdown)

I'm not sure what does this break.....

@derokorian
Copy link

@jjchiw thanks much this has fixed the problem for me! I have this on 7 or 8 places, and changing this did not break any of my usages... wondering why it was changed in the first place though... May submit a PR later with this change after some more testing.

ghost pushed a commit to TTouka/ui-select that referenced this issue Jul 3, 2015
…eDirective into

uiSelectDirective

* vid. angular-ui#1006 (comment)
* Passing all existing tests
@evillemez
Copy link

Yeah... this is killing me right now :(

@flaub
Copy link

flaub commented Dec 21, 2015

Still broken in 0.13.2

@andrecbr
Copy link

That problem have many issues but without fix, just pull request.
Many issues related are opened and closed without solution. It's frustrating!

@wesleycho
Copy link
Contributor

Updated Plunker here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants