From c4cf359233e1044864539383912b9ba0432e149d Mon Sep 17 00:00:00 2001
From: Alan Agius <alanagius@google.com>
Date: Tue, 28 May 2024 09:50:28 +0000
Subject: [PATCH] fix(@angular/build): print Sass `@warn` location
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When using the `@warn` directive, the `span` entry in the warning object is often undefined. Instead, the `stack` property is populated.

```js
{
  "warnings": [
    {
      "deprecation": false,
      "deprecationType": null,
      "span": undefined,
      "stack": "projects/foo/src/app/app.component.scss 1:1  root stylesheet\n",
      "message": "some message"
    }
  ]
}
```

### Before
```
▲ [WARNING] some message [plugin angular-sass]
```

### Now
```
▲ [WARNING] some message [plugin angular-sass]

  projects/foo/src/app/app.component.scss 1:1  root stylesheet
```

Closes: #27726
(cherry picked from commit 4a879a93c4972327aed0d48148cd71f6c17a9f14)
---
 .../src/tools/esbuild/stylesheets/sass-language.ts | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/packages/angular/build/src/tools/esbuild/stylesheets/sass-language.ts b/packages/angular/build/src/tools/esbuild/stylesheets/sass-language.ts
index eda137f78f12..c0fb7c7397fb 100644
--- a/packages/angular/build/src/tools/esbuild/stylesheets/sass-language.ts
+++ b/packages/angular/build/src/tools/esbuild/stylesheets/sass-language.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import type { OnLoadResult, PartialMessage, ResolveResult } from 'esbuild';
+import type { OnLoadResult, PartialMessage, PartialNote, ResolveResult } from 'esbuild';
 import { dirname, join, relative } from 'node:path';
 import { fileURLToPath, pathToFileURL } from 'node:url';
 import type { CanonicalizeContext, CompileResult, Exception, Syntax } from 'sass';
@@ -140,7 +140,15 @@ async function compileString(
         },
       ],
       logger: {
-        warn: (text, { deprecation, span }) => {
+        warn: (text, { deprecation, stack, span }) => {
+          const notes: PartialNote[] = [];
+          if (deprecation) {
+            notes.push({ text });
+          }
+          if (stack && !span) {
+            notes.push({ text: stack });
+          }
+
           warnings.push({
             text: deprecation ? 'Deprecation' : text,
             location: span && {
@@ -150,7 +158,7 @@ async function compileString(
               line: span.start.line + 1,
               column: span.start.column,
             },
-            notes: deprecation ? [{ text }] : undefined,
+            notes,
           });
         },
       },