Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type checking for protractor.conf.js file #13958

Closed
doggy8088 opened this issue Mar 20, 2019 · 1 comment
Closed

add type checking for protractor.conf.js file #13958

doggy8088 opened this issue Mar 20, 2019 · 1 comment
Labels
area: @schematics/angular feature Issue that requests a new feature P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Milestone

Comments

@doggy8088
Copy link
Contributor

🚀 Feature request

Command (mark with an x)

- [x] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description

add type checking for protractor.conf.js file

Describe the solution you'd like

Add some more comment in the e2e/protractor.conf.js file

+// @ts-check
// Protractor configuration file, see link for more information
// https://github.com/angular/protractor/blob/master/lib/config.ts

const { SpecReporter } = require('jasmine-spec-reporter');

+/**
+ * @type { import("protractor").Config }
+ */
exports.config = {
  allScriptsTimeout: 11000,
  specs: [
    './src/**/*.e2e-spec.ts'
  ],
  capabilities: {
    'browserName': 'chrome'
  },
  directConnect: true,
  baseUrl: 'http://localhost:4200/',
  framework: 'jasmine',
  jasmineNodeOpts: {
    showColors: true,
    defaultTimeoutInterval: 30000,
    print: function() {}
  },
  onPrepare() {
    require('ts-node').register({
      project: require('path').join(__dirname, './tsconfig.json')
    });
    jasmine.getEnv().addReporter(new SpecReporter({ spec: { displayStacktrace: true } }));
  }
};

Describe alternatives you've considered

No.

@alan-agius4 alan-agius4 added feature Issue that requests a new feature P5 The team acknowledges the request but does not plan to address it, it remains open for discussion area: @schematics/angular labels Mar 21, 2019
@ngbot ngbot bot added this to the Backlog milestone Mar 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @schematics/angular feature Issue that requests a new feature P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Development

No branches or pull requests

2 participants