Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip appeaers in the opposite side of the screen (RTL) #1085

Closed
theunreal opened this issue Aug 19, 2016 · 8 comments · Fixed by #1830
Closed

Tooltip appeaers in the opposite side of the screen (RTL) #1085

theunreal opened this issue Aug 19, 2016 · 8 comments · Fixed by #1830
Assignees
Labels
i18n This issue is related to internationalization P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@theunreal
Copy link

theunreal commented Aug 19, 2016

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Tooltip appeaers below / in right of / in left of the object

What is the current behavior?

Tooltip appears in the wrong position, hidden in screen corners. (RTL pages)

My app has 2 sidebars:

  1. Right sidebar
  2. Left sidebar

I have MdList in my Left sidebar, and [md-tooltip] on each item.
The tooltip appears in the right side of my screen, at the end of the right (not the left!) sidebar, in a total wrong position and the other side of the screen.

Tested also outside the md list, and it still showing in a wrong position.

What are the steps to reproduce?

Having 2 sidebars, left and right.
Put a link with md tooltip, and the tooltip will appears in the other side of the screen.

Might work with bugged position on any RTL website, not sure

What is the use-case or motivation for changing an existing behavior?

Md Tooltip supports RTL websites

Which versions of Angular, Material, OS, browsers are affected?

Angular 2 Rc.5, material v7-4

@jtc10005
Copy link

I'm having this same issue. Here is a plunk showing the issue.
https://plnkr.co/edit/yuPzIJ?p=preview

@jelbourn jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent i18n This issue is related to internationalization labels Nov 3, 2016
@jelbourn
Copy link
Member

jelbourn commented Nov 3, 2016

@andrewseguin this should likely do the same thing Kara is doing in md-menu for RTL

@andrewseguin
Copy link
Contributor

Talked with @EladBezalel and he came up with a suggestion to support RTL/LTR but also provide a way to enforce placement regardless of direction.

He suggested having the states Left, Right, Top, Bottom for hard-coding where the tooltip will appear. In addition, the states Start and End would respect left/right depending on RTL/LTR.

What do you guys think about this?

@jelbourn
Copy link
Member

jelbourn commented Nov 10, 2016

In which situations would you want left / right regardless of layout direction? I'm worried that people would prefer those settings and accidentally make it RTL-unfriendly.

@EladBezalel
Copy link
Member

Having a fixed position element that is not related to the layout?
Why to restrict users?

@jelbourn
Copy link
Member

@EladBezalel do you have a specific example in mind?

@EladBezalel
Copy link
Member

@jelbourn maybe something like that?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i18n This issue is related to internationalization P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants