Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectedOverlayDirective.positions is not assignable? #988

Closed
jessedhillon opened this issue Aug 10, 2016 · 2 comments
Closed

ConnectedOverlayDirective.positions is not assignable? #988

jessedhillon opened this issue Aug 10, 2016 · 2 comments

Comments

@jessedhillon
Copy link

Bug, feature request, or proposal:

See this commit jessedhillon@eedd965

The positions attribute on a connected-overlay element is ignored.

What is the expected behavior?

When the positions attribute is set on an element with [connected-overlay] the component should use those ConnectedPositionPair instances.

What is the current behavior?

The default positions are always used.

What are the steps to reproduce?

Check out my bug-overlay-directive-positions branch. I've added one new spec and fixture to demonstrate the issue.

I couldn't get your plunkr template to demonstrate the issue, or load the overlay directive, because the angular version is too low. I was just recreating the test component from my branch anyhow.

What is the use-case or motivation for changing an existing behavior?

Users of connected-overlay would want to align the overlay to the trigger

Which versions of Angular, Material, OS, browsers are affected?

angular-2.0.0-alpha-7.2

Is there anything else we should know?

I dug down into the JS internals a bit and the propMetadata map returned when reflecting on ConnectedOverlayDirective only has the origin key in it, it should have a positions key as well.

@jessedhillon
Copy link
Author

I think something else was the issue here, disregard.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant