Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub arm64 macOS runner is now available, may enable test for it #58

Closed
laggykiller opened this issue Feb 26, 2024 · 2 comments
Closed

Comments

@laggykiller
Copy link
Contributor

laggykiller commented Feb 26, 2024

Source: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

You may want to build macOS arm64 wheel on arm64 CI runner so you can run test for both x86_64 and arm64 part of the wheel:

# TODO: Use arm64 CI runner when available

@laggykiller
Copy link
Contributor Author

laggykiller commented Feb 28, 2024

I am trying to build pywebp with macos-14. During cibuildwheel test for the built universal2 wheel, it errored out as venv for testing x86_64 is reused for testing arm64, which contained x86_64 version of Pillow and cause error: https://github.com/laggykiller/pywebp/actions/runs/8074750021/job/22060570579#step:5:2147 . This is also discussed in pypa/cibuildwheel#1746 (comment) and fixed in pypa/cibuildwheel#1750 .

I can confirm that pywebp builds without error with master branch of cibuildwheel which contain that fix (https://github.com/laggykiller/pywebp/actions/runs/8074902563/job/22060951096), however cibuildwheel has not released a new version that contain that fix. I will submit a PR once cibuildwheel release a new version.

btw Beside allowing tests, seems like using macos-14 shaves 1 minute of build time

btw From working on my personal project that also use conan, conan profile is not regenerated if it already exist and -f flag not present. Though it probably won't affect this project (This project does not use the cmake profile generated by conan), rebuilding without updated conan profile may cause much headache (See tttapa/py-build-cmake#24). While we are at it, I will also add -f flag to conan profile detect in the PR.

@anibali
Copy link
Owner

anibali commented Feb 28, 2024

That all sounds good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants