-
Notifications
You must be signed in to change notification settings - Fork 4
UI: Add toggling effect on buttons #1141
base: develop
Are you sure you want to change the base?
Conversation
Thanks @keshakaneria for the help , Please have a look! |
Looks like I forgot to remove a console.log statement lol which i used to debug. Hope this isn't a big deal or should I remove it? |
Codecov Report
@@ Coverage Diff @@
## develop #1141 +/- ##
==========================================
Coverage ? 87.08%
==========================================
Files ? 85
Lines ? 4057
Branches ? 237
==========================================
Hits ? 3533
Misses ? 453
Partials ? 71 Continue to review full report at Codecov.
|
I guess let us keep the code clean. So you will have to remove it :) Also, do squash it so that, it is ready to merge ⚡ |
I will. One more thing I saw an issue in backend-repo where the one who completed or took part in OSH has to write a blog about it . But i guess it is specifically for that repo . Can we do the same for vms? 😯 |
Yeah sure you can. Let me know the topic of your blog if you have one otherwise I will provide you one. Can you just link that issue of blog which you saw here? |
anitab-org/mentorship-backend#904 My blog will focus mainly about the early problems i faced during my first PR and the increase in my confidence after the first PR . I would love to mention how easy it is to take part in OSH when the maintainers are ready to help you giving their best. etc Something sort of this😄. |
Here it is. Go for it. |
c81f3ee
to
0c4db04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@keshakaneria @sanchibansal340 This hasn't been reviewed yet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry, I might have missed this issue for review. It looks good now. We are ready to go with this 🥳
Added toggling effect on buttons(nav tabs) in administrator/settings.html
Fixes #1134
Type of Change:
Mocks
How Has This Been Tested?
Manually
Checklist:
Code/Quality Assurance Only