Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation about connection IDs for IBC client #42

Closed
yito88 opened this issue Dec 10, 2021 · 3 comments
Closed

Validation about connection IDs for IBC client #42

yito88 opened this issue Dec 10, 2021 · 3 comments
Assignees
Labels
bug Something isn't working IBC ledger

Comments

@yito88
Copy link
Member

yito88 commented Dec 10, 2021

IBC needs to store IBC connection IDs for each IBC client.
However, there is no validation about "clients/{identifier}/connections" for now.

IBC VP has to check if a new connection ID is stored for the corresponding client when the connection is created.

┆Issue is synchronized with this Asana task by Unito

@yito88 yito88 added bug Something isn't working IBC labels Dec 10, 2021
@yito88 yito88 self-assigned this Dec 10, 2021
@sync-by-unito sync-by-unito bot closed this as completed Feb 3, 2022
@juped juped reopened this Feb 3, 2022
@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@yito88 yito88 mentioned this issue Aug 10, 2022
29 tasks
@cwgoes
Copy link
Collaborator

cwgoes commented Jan 12, 2023

@yito88 what is the status of this - have we done this already?

@yito88
Copy link
Member Author

yito88 commented Jan 16, 2023

Aleks has worked on this in https://github.com/anoma/namada/tree/aleks/verify-ibc-connection-list. It hasn't been merged yet.
This issue is not fatal because the list is not used.
I'd like to merge it after updating ibc-rs (#840).

Only the IBC relayer would use the list. The current relayer can get it in another way.

@yito88
Copy link
Member Author

yito88 commented May 12, 2023

Fixed by #1217

@yito88 yito88 closed this as completed May 12, 2023
@github-project-automation github-project-automation bot moved this from Todo to Tested in Devnet in Namada-Old May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working IBC ledger
Projects
No open projects
Status: Tested in Devnet
Development

Successfully merging a pull request may close this issue.

4 participants