Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a simple fee system #958

Closed
adrianbrink opened this issue Dec 23, 2022 · 1 comment · Fixed by #962
Closed

Implement a simple fee system #958

adrianbrink opened this issue Dec 23, 2022 · 1 comment · Fixed by #962
Assignees

Comments

@adrianbrink
Copy link
Member

adrianbrink commented Dec 23, 2022

No description provided.

@grarco
Copy link
Collaborator

grarco commented Dec 23, 2022

Quick implementation for testnets:

  • Check balance in mempool_validate, reject tx if insufficient
  • Check balance in process_proposal, reject tx if insufficient
  • Check balance in finalize_block, reject tx if insufficient
  • Burn fees in finalize_block (even if insufficient funds, drain whatever possible)
  • Constant fee for every transaction (no protocol parameter to avoid the need for a chain restart)
  • Fee can only be paid in NAM

@grarco grarco mentioned this issue Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants