From 9d3614daecb80f97931e6ec9c8d588f43361fe70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Zemanovi=C4=8D?= Date: Sat, 20 May 2023 11:12:25 +0200 Subject: [PATCH] shared/tx/submit_validator_commission_change: print err even with force --- shared/src/ledger/tx.rs | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/shared/src/ledger/tx.rs b/shared/src/ledger/tx.rs index 8b2a9d85ed..d9d7cdf410 100644 --- a/shared/src/ledger/tx.rs +++ b/shared/src/ledger/tx.rs @@ -528,18 +528,11 @@ pub async fn submit_validator_commission_change< let validator = args.validator.clone(); if rpc::is_validator(client, &validator).await { if args.rate < Decimal::ZERO || args.rate > Decimal::ONE { - if args.tx.force { - eprintln!( - "Invalid new commission rate, received {}", - args.rate - ); - Ok(()) - } else { - Err(Error::InvalidCommisionRate(args.rate)) + eprintln!("Invalid new commission rate, received {}", args.rate); + if !args.tx.force { + return Err(Error::InvalidCommisionRate(args.rate)); } - } else { - Ok(()) - }?; + } let pipeline_epoch_minus_one = epoch + params.pipeline_len - 1;