From c335b741112717937b008989f439db54fb179e4e Mon Sep 17 00:00:00 2001 From: Yagiz Nizipli Date: Fri, 14 Apr 2023 07:34:20 -0400 Subject: [PATCH] url: handle URL.canParse without base parameter PR-URL: https://github.com/nodejs/node/pull/47547 Reviewed-By: Debadree Chatterjee Reviewed-By: Matthew Aitken Reviewed-By: Robert Nagy Reviewed-By: Luigi Pinca --- src/node_url.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_url.cc b/src/node_url.cc index 2911e833f77c88..9ee0b43b4a4d05 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -115,7 +115,7 @@ void BindingData::DomainToUnicode(const FunctionCallbackInfo& args) { // TODO(@anonrig): Add V8 Fast API for CanParse method void BindingData::CanParse(const FunctionCallbackInfo& args) { - CHECK_GE(args.Length(), 2); + CHECK_GE(args.Length(), 1); CHECK(args[0]->IsString()); // input // args[1] // base url