From c92199c34560ad712b898f6774c29fed2e6d04c8 Mon Sep 17 00:00:00 2001 From: Helen Bailey Date: Wed, 5 Jul 2023 14:06:56 -0400 Subject: [PATCH 1/2] Prep amazon.aws 5.5.2 --- CHANGELOG.rst | 15 +++++++++++++++ changelogs/changelog.yaml | 19 +++++++++++++++++++ .../1589-return_false_when_no_change..yml | 3 --- .../1615-no_formatted_with_extra_space.yml | 3 --- ...ate-eip-when-connectivity_type=private.yml | 2 -- changelogs/fragments/20230627-ci-fixup.yml | 3 --- .../20230704-add_github_workflow.yml | 4 ---- galaxy.yml | 2 +- 8 files changed, 35 insertions(+), 16 deletions(-) delete mode 100644 changelogs/fragments/1589-return_false_when_no_change..yml delete mode 100644 changelogs/fragments/1615-no_formatted_with_extra_space.yml delete mode 100644 changelogs/fragments/1632-changes-to-no-allocate-eip-when-connectivity_type=private.yml delete mode 100644 changelogs/fragments/20230627-ci-fixup.yml delete mode 100644 changelogs/fragments/20230704-add_github_workflow.yml diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 6e07527c13f..5fc492d0c6e 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -5,6 +5,21 @@ amazon.aws Release Notes .. contents:: Topics +v5.5.2 +====== + +Release Summary +--------------- + +This release brings few bugfixes. + +Bugfixes +-------- + +- Fixes changed status to report False when no change has been made. The module had incorrectly always reported a change. (https://github.com/ansible-collections/amazon.aws/pull/1589) +- Fixes to the stack trace output, where it does not contain spaces between each character. The module had incorrectly always outputted extra spaces between each character. (https://github.com/ansible-collections/amazon.aws/pull/1615) +- ec2_vpc_nat_gateway - fixes to nat gateway so that when the user creates a private NAT gateway, an Elastic IP address should not be allocated. The module had inncorrectly always allocate elastic IP address when creating private nat gateway (https://github.com/ansible-collections/amazon.aws/pull/1632). + v5.5.1 ====== diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index 2daf440bbe1..49b76773a0e 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -1732,3 +1732,22 @@ releases: - release-summary.yml - test-reqs.yml release_date: '2023-06-07' + 5.5.2: + changes: + bugfixes: + - Fixes changed status to report False when no change has been made. The module + had incorrectly always reported a change. (https://github.com/ansible-collections/amazon.aws/pull/1589) + - Fixes to the stack trace output, where it does not contain spaces between + each character. The module had incorrectly always outputted extra spaces between + each character. (https://github.com/ansible-collections/amazon.aws/pull/1615) + - ec2_vpc_nat_gateway - fixes to nat gateway so that when the user creates a + private NAT gateway, an Elastic IP address should not be allocated. The module + had inncorrectly always allocate elastic IP address when creating private + nat gateway (https://github.com/ansible-collections/amazon.aws/pull/1632). + fragments: + - 1589-return_false_when_no_change..yml + - 1615-no_formatted_with_extra_space.yml + - 1632-changes-to-no-allocate-eip-when-connectivity_type=private.yml + - 20230627-ci-fixup.yml + - 20230704-add_github_workflow.yml + release_date: '2023-07-05' diff --git a/changelogs/fragments/1589-return_false_when_no_change..yml b/changelogs/fragments/1589-return_false_when_no_change..yml deleted file mode 100644 index 5b5367c5f63..00000000000 --- a/changelogs/fragments/1589-return_false_when_no_change..yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -bugfixes: -- Fixes changed status to report False when no change has been made. The module had incorrectly always reported a change. (https://github.com/ansible-collections/amazon.aws/pull/1589) \ No newline at end of file diff --git a/changelogs/fragments/1615-no_formatted_with_extra_space.yml b/changelogs/fragments/1615-no_formatted_with_extra_space.yml deleted file mode 100644 index 693362b6950..00000000000 --- a/changelogs/fragments/1615-no_formatted_with_extra_space.yml +++ /dev/null @@ -1,3 +0,0 @@ ---- -bugfixes: -- Fixes to the stack trace output, where it does not contain spaces between each character. The module had incorrectly always outputted extra spaces between each character. (https://github.com/ansible-collections/amazon.aws/pull/1615) \ No newline at end of file diff --git a/changelogs/fragments/1632-changes-to-no-allocate-eip-when-connectivity_type=private.yml b/changelogs/fragments/1632-changes-to-no-allocate-eip-when-connectivity_type=private.yml deleted file mode 100644 index 4b820a3498f..00000000000 --- a/changelogs/fragments/1632-changes-to-no-allocate-eip-when-connectivity_type=private.yml +++ /dev/null @@ -1,2 +0,0 @@ -bugfixes: -- ec2_vpc_nat_gateway - fixes to nat gateway so that when the user creates a private NAT gateway, an Elastic IP address should not be allocated. The module had inncorrectly always allocate elastic IP address when creating private nat gateway (https://github.com/ansible-collections/amazon.aws/pull/1632). \ No newline at end of file diff --git a/changelogs/fragments/20230627-ci-fixup.yml b/changelogs/fragments/20230627-ci-fixup.yml deleted file mode 100644 index 160eb26b459..00000000000 --- a/changelogs/fragments/20230627-ci-fixup.yml +++ /dev/null @@ -1,3 +0,0 @@ -trivial: -- CI fixup - ``include:`` should be ``include_tasks:``. -- CI fixup - YAML ``Null`` no longer matches any explicit parameter type requirements. diff --git a/changelogs/fragments/20230704-add_github_workflow.yml b/changelogs/fragments/20230704-add_github_workflow.yml deleted file mode 100644 index ae3717e4019..00000000000 --- a/changelogs/fragments/20230704-add_github_workflow.yml +++ /dev/null @@ -1,4 +0,0 @@ -trivial: - - "Add sanity, units and linters and changelog GitHub workflows." - - "Fix linting and validation errors across several modules." - - "Remove Python < 3.6 compatibility code for unit tests." diff --git a/galaxy.yml b/galaxy.yml index c587adc3830..9599ead2970 100644 --- a/galaxy.yml +++ b/galaxy.yml @@ -1,6 +1,6 @@ namespace: amazon name: aws -version: 5.5.1 +version: 5.5.2 readme: README.md authors: - Ansible (https://github.com/ansible) From 223cd84471977e448ef4dd177576a1f49b9c42e4 Mon Sep 17 00:00:00 2001 From: Helen Bailey Date: Wed, 5 Jul 2023 15:10:37 -0400 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Alina Buzachis --- CHANGELOG.rst | 4 ++-- changelogs/changelog.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 5fc492d0c6e..5f1ffa8cca7 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -16,8 +16,8 @@ This release brings few bugfixes. Bugfixes -------- -- Fixes changed status to report False when no change has been made. The module had incorrectly always reported a change. (https://github.com/ansible-collections/amazon.aws/pull/1589) -- Fixes to the stack trace output, where it does not contain spaces between each character. The module had incorrectly always outputted extra spaces between each character. (https://github.com/ansible-collections/amazon.aws/pull/1615) +- cloudwatchevent_rule - Fixes changed status to report False when no change has been made. The module had incorrectly always reported a change. (https://github.com/ansible-collections/amazon.aws/pull/1589) +- lambda_execute - Fixes to the stack trace output, where it does not contain spaces between each character. The module had incorrectly always outputted extra spaces between each character. (https://github.com/ansible-collections/amazon.aws/pull/1615) - ec2_vpc_nat_gateway - fixes to nat gateway so that when the user creates a private NAT gateway, an Elastic IP address should not be allocated. The module had inncorrectly always allocate elastic IP address when creating private nat gateway (https://github.com/ansible-collections/amazon.aws/pull/1632). v5.5.1 diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml index 49b76773a0e..6215565fe52 100644 --- a/changelogs/changelog.yaml +++ b/changelogs/changelog.yaml @@ -1735,9 +1735,9 @@ releases: 5.5.2: changes: bugfixes: - - Fixes changed status to report False when no change has been made. The module + - cloudwatchevent_rule - Fixes changed status to report False when no change has been made. The module had incorrectly always reported a change. (https://github.com/ansible-collections/amazon.aws/pull/1589) - - Fixes to the stack trace output, where it does not contain spaces between + - lambda_execute - Fixes to the stack trace output, where it does not contain spaces between each character. The module had incorrectly always outputted extra spaces between each character. (https://github.com/ansible-collections/amazon.aws/pull/1615) - ec2_vpc_nat_gateway - fixes to nat gateway so that when the user creates a