Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_instance -> app_callback -> set_password doesn't work #1449

Closed
1 task done
pluto00987 opened this issue Mar 30, 2023 · 6 comments · Fixed by #1468
Closed
1 task done

ec2_instance -> app_callback -> set_password doesn't work #1449

pluto00987 opened this issue Mar 30, 2023 · 6 comments · Fixed by #1468
Assignees
@alinabuzachis
Labels
bug This issue/PR relates to a bug module module plugins plugin (any type)

Comments

@pluto00987
Copy link
Contributor

Summary

Setting the 'set_password' option doesn't product the expected result.

Problem seems to be here

amazon.aws/plugins/modules/ec2_instance.py

Line 1236 in 8acb076

passwd=params.get('aap_callback').get('set_passwd'),

where it's passing 'set_passwd' when the actual variable name is 'set_password' set here

amazon.aws/plugins/modules/ec2_instance.py

Line 2046 in 8acb076

set_password=dict(type='str', no_log=True),

Seems to be a typo included in #1199 as it worked prior to that.

Issue Type

Bug Report

Component Name

ec2_instance

Ansible Version

$ ansible --version

Collection Versions

version 5.4.0
Also present in main branch

AWS SDK versions

$ pip show boto boto3 botocore

Configuration

$ ansible-config dump --only-changed

OS / Environment

No response

Steps to Reproduce



Expected Results


A line should be present in user_data for the new instance, which sets the local admin password


Actual Results


It's not there


Code of Conduct


    

  •  I agree to follow the Ansible Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
      



  

  @pluto00987





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

  





      


        


  
    

      
          
Neglected to mention, this is for windows instances, with 'windows: true' also set under app_callback.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @ansibullbot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
cc @jillr @ryansb @s-hertel @tremble

click here for bot help


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @ansibullbot
ansibullbot




            added
      

  bug

  This issue/PR relates to a bug

      

  module

  module

      

  needs_triage


      

  plugins

  plugin (any type)

  labels


      Mar 31, 2023

    

  








      

  
      



  

  @alinabuzachis





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

  





      


        


  
    

      
          
@pluto00987 Thank you for raising this issue. Would you be willing to open a Pull Request with a fix?

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            


    

    

      
    

    


      

          @GomathiselviS
GomathiselviS




              self-assigned this


      Apr 3, 2023

    

  



    


    

    

      
    

    


      

          @GomathiselviS
GomathiselviS




              removed their assignment


      Apr 3, 2023

    

  



    

    

      
    

    


      

          @GomathiselviS
GomathiselviS




          removed
  the 

  jira

 label


      Apr 3, 2023

    

  








      

  
      



  

  @UNiXMIT





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

      

      
            UNiXMIT
  

      

      

      commented


        Apr 24, 2023


      
    


  





      


        


  
    

      
          
Nooooooo this has completely broken my Ansible playbooks to create Windows instances. Is there a workaround so that I can still automate creation of my Windows instances?

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    

      
    

    


      

          @alinabuzachis
alinabuzachis




              self-assigned this


      Apr 24, 2023

    

  



  

  

    
  


  

      

    @alinabuzachis
alinabuzachis



    mentioned this issue
    
      Apr 24, 2023
    





  


  

      
   Merged

  







  









      

  
      



  

  @UNiXMIT





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

      

      
            UNiXMIT
  

      

      

      commented


        Apr 24, 2023


      
    


  





      


        


  
    

      
          
Happy days. I manually changed the line in the file and now it's working.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
      



  

  @alinabuzachis





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Collaborator


      

  


  

    

  





      


        


  
    

      
          


Happy days. I manually changed the line in the file and now it's working.




@UNiXMIT We have a fix for that bug #1468.

      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
            

    


  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      Apr 26, 2023
    
    

      


  

    

      


  

      
        @alinabuzachis
  





      

        
          Reabse (#1468)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          f399fb7
        
      

    

  

    

      
Pick up app_callback -> set_password rather than app_callback -> set_passwd

SUMMARY

Closes: #1449
Pick up app_callback -> set_password rather than app_callback -> set_passwd

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell

    




    

  




  


  
    
  
  

    
  alinabuzachis 

      added a commit
        to alinabuzachis/amazon.aws
      that referenced
      this issue

    
      Apr 26, 2023
    
    

      


  

    

      


  

      
        @alinabuzachis
  





      

        
          Reabse (ansible-collections#1468)
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          198e4b3
        
      

    

  

    

      
Pick up app_callback -> set_password rather than app_callback -> set_passwd

SUMMARY

Closes: ansible-collections#1449
Pick up app_callback -> set_password rather than app_callback -> set_passwd

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell

    




    

  




  

  

    
  


  

      

    @alinabuzachis
alinabuzachis



    mentioned this issue
    
      Apr 26, 2023
    





  


  

      
   Merged

  







  




  


  
    
  
  

    
  tremble 

      pushed a commit
        to alinabuzachis/amazon.aws
      that referenced
      this issue

    
      May 3, 2023
    
    

      


  

    

      


  

      
        @alinabuzachis
      
        @tremble
  





      

        
          Backport ansible-collections#1468
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          2656b24
        
      

    

  

    

      
Pick up app_callback -> set_password rather than app_callback -> set_passwd

SUMMARY

Closes: ansible-collections#1449
Pick up app_callback -> set_password rather than app_callback -> set_passwd

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell

    




    

  




  


  
    
  
  

    
  softwarefactory-project-zuul bot

      pushed a commit
      that referenced
      this issue

    
      May 3, 2023
    
    

      


  

    

      


  

      
        @alinabuzachis
  





      

        
          [manual backport stable-5] Pick up app_callback -> set_password rathe…
        

          
            
          

      


      

          

    
    
    

  

    


      


      

      


      
      

        
          2e5a81a
        
      

    

  

    

      
…r than app_callback -> set_passwd (#1482)

[manual backport stable-5] Pick up app_callback -> set_password rather than app_callback -> set_passwd

Pick up app_callback -> set_password rather than app_callback -> set_passwd
SUMMARY
Closes: #1449
Pick up app_callback -> set_password rather than app_callback -> set_passwd
ISSUE TYPE
Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Mark Chappell
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Jill R

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @alinabuzachis
  
    alinabuzachis
    

      








      


  


  

    Labels
  



    

      

    bug

  This issue/PR relates to a bug
  

    module

  module
  

    plugins

  plugin (any type)








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      Pick up app_callback -> set_password rather than app_callback -> set_passwd

    
      alinabuzachis/amazon.aws
    





    
  




        
      

    

  
      

  

    

      5 participants
    

    

        
          @pluto00987 
        
          @UNiXMIT 
        
          @alinabuzachis 
        
          @GomathiselviS 
        
          @ansibullbot